From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6203A264FB1; Wed, 30 Apr 2025 15:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746025630; cv=none; b=ottegEwv6smrom21ppRNwq8t7Iv4gWHzeXbNa2bBDe0WmOyWHyK7xJbKZGbI1PihJt3Dr3TSjbocOlUkqtBzOSegRLYkNcJc26qRNrWQkvlzVuBZ/KNICcSGrMI9wi4na830XxFwa2bsFo7ORs1yy+xsy1Zr4z9EpcMnlKPRtbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746025630; c=relaxed/simple; bh=l2OCUUbhAtEJhunFl9s7WpfywU8jr7sBKcPv0mzaIgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ucDyg0PAK1ofEkouIVYWa/qB6b0ZoknJiilcl1cC8pxoE4s9HihVs2EOqXhZGaLUnZ359zLSZv6M23OjsomJb59VNeFnFaMJjufV+bverJq0wfuVsD8US08hxzmEzbm6PNfh/osQ1TxKPguLMejcYB+k/w9S18Jbrtdph+21oK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hpzK8cQC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hpzK8cQC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D033C4CEEC; Wed, 30 Apr 2025 15:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746025630; bh=l2OCUUbhAtEJhunFl9s7WpfywU8jr7sBKcPv0mzaIgc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hpzK8cQC9tKAyzjvucQ9iN+kZ/LjIAStnT1l0CirHdaPkndNg1pfw6OJ2LCoF4AOW GGn2qXA9tiNNWoMthMznaC/ZMrTlID39WzPzb5taSbvGXnwVQGcrpx2X1jM+iAp4uj bjZHbv9og3QGCPaHLwLIr3u9R2FdiEgfRb/6DQ3qyN8lOhKSQ/8vK2T1IM2XIHUsCy wblcZshwsKly9cfp0H4/ppWxPvq/Do7CXQkCfoBW7kG+qfzncarfI9NaXYKa7lkaIJ sBWePkWqLGa2Jthrbe9Qz/dEiYdungevR6nygKNP33Ogu/h+IYzusp03dndOn5euul uUMdNgvNtGmgA== From: Jeff Layton Date: Wed, 30 Apr 2025 08:06:53 -0700 Subject: [PATCH v6 07/10] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250430-reftrack-dbgfs-v6-7-867c29aff03a@kernel.org> References: <20250430-reftrack-dbgfs-v6-0-867c29aff03a@kernel.org> In-Reply-To: <20250430-reftrack-dbgfs-v6-0-867c29aff03a@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin Cc: Kuniyuki Iwashima , Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3214; i=jlayton@kernel.org; h=from:subject:message-id; bh=l2OCUUbhAtEJhunFl9s7WpfywU8jr7sBKcPv0mzaIgc=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBoEjyUxlaClx2l1uovcL0XdFjxbdtx9MQCIdkCR ftLMdlZ6kyJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaBI8lAAKCRAADmhBGVaC FQB3D/9PQ1WZ8PairKuf37rAmKR3/4iexcIQGa+ifz04gdQ9A+xqtthSJNBUJ+gl3BkhwNNi+Fr 2nFviSEP1hVlJFFpmkRoJbf7noJ0CiuWVLszWK9vHI4s/UW8iJwKbnaC+8CgTnXeuaoKyb/0cw7 qJ8xFOC+bxSd96EjSHb/4FCmIvruHcJovfQR5AxanWZVInqg17C4Gl1l8ddNyEICZNBwvrKkNJQ OfcSXOLNFdYFDjtd0jIt5iF9vX+VkCcw6IHyweOv26kFW9A2yruqSefxdOkWHXbsOo85fFji2+J 8uU2nEVhzBMdENTMF6KfrdvjIOc50qGN66LxecGWkDB5dL2YABnsuDYn67udtImpWVEYFdMrxgO HDj8kEY4fj1FUpkYHKq9/0wBmQIMlDKES6m3JQGPy2SQ756V16iJqKGHcXtRG7Vc1ZieXjXw6GW GQdAOT/hwg0gqbyj2SET1X1TiZXb2zOJALcCXf2H9WF4Wjjndp+ZANWm33pkySfxGNtiCuNETra tP7tCwliNziK6/QElPi9r8b3qFlteEqp+1leWgbrys0E2lO1/J7z0U+Pnqa21cBdj98QzcoIkCs Wy07gDdc0VYEvIUW1+70jlrnmtEkiUqB+Y3VKurcn3/cnRZiyVGF+PFALyYmT/EsJDWWXrtRx8Y BQp886aCK+iTJOw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 10 ++++++++++ lib/ref_tracker.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h index c6e65d7ef4d4fc74c60fcabd19166c131d4173e2..210f26e2528f23bea3b713a57ac27c730bd100ce 100644 --- a/include/linux/ref_tracker.h +++ b/include/linux/ref_tracker.h @@ -21,6 +21,7 @@ struct ref_tracker_dir { const char *class; /* object classname */ #ifdef CONFIG_DEBUG_FS struct dentry *dentry; + struct dentry *symlink; #endif char name[32]; #endif @@ -29,6 +30,7 @@ struct ref_tracker_dir { #ifdef CONFIG_REF_TRACKER void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir); +void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...); static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, unsigned int quarantine_count, @@ -45,6 +47,7 @@ static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, dir->class = class; #ifdef CONFIG_DEBUG_FS dir->dentry = NULL; + dir->symlink = NULL; #endif strscpy(dir->name, name, sizeof(dir->name)); ref_tracker_dir_debugfs(dir); @@ -80,6 +83,10 @@ static inline void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) { } +static inline void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ +} + static inline void ref_tracker_dir_exit(struct ref_tracker_dir *dir) { } @@ -113,6 +120,9 @@ static inline int ref_tracker_free(struct ref_tracker_dir *dir, return 0; } +static inline void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ +} #endif #endif /* _LINUX_REF_TRACKER_H */ diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index 3ee4fd0f33407881cfa140dcb7d8b40e3c2722de..16ef752e52c230763f2832c312793d27da47c608 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -392,8 +392,36 @@ void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) } EXPORT_SYMBOL(ref_tracker_dir_debugfs); +void __ostream_printf ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ + char name[NAME_MAX + 1]; + va_list args; + int ret; + + /* Already created, or dentry doesn't exist? Do nothing */ + if (!IS_ERR_OR_NULL(dir->symlink) || IS_ERR_OR_NULL(dir->dentry)) + return; + + va_start(args, fmt); + ret = vsnprintf(name, sizeof(name), fmt, args); + va_end(args); + name[sizeof(name) - 1] = '\0'; + + if (ret < sizeof(name)) + dir->symlink = debugfs_create_symlink(name, ref_tracker_debug_dir, + dir->dentry->d_name.name); + else + dir->symlink = ERR_PTR(-ENAMETOOLONG); + + if (IS_ERR(dir->symlink)) + pr_warn("ref_tracker: unable to create debugfs symlink for %s: %pe\n", + name, dir->symlink); +} +EXPORT_SYMBOL(ref_tracker_dir_symlink); + static void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir) { + debugfs_remove(dir->symlink); debugfs_remove(dir->dentry); } -- 2.49.0