public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: avimalin@gmail.com
Cc: vimal.agrawal@sophos.com, linux-kernel@vger.kernel.org,
	pablo@netfilter.org, netfilter-devel@vger.kernel.org,
	fw@strlen.de, anirudh.gupta@sophos.com
Subject: Re: [PATCH v2] nf_conntrack: sysctl: expose gc worker scan interval via sysctl
Date: Wed, 30 Apr 2025 09:11:40 +0200	[thread overview]
Message-ID: <20250430071140.GA29525@breakpoint.cc> (raw)
In-Reply-To: <20250430064342.62592-1-vimal.agrawal@sophos.com>

> v2: Don't allow non-init_net ns to alter this global sysctl

Looks good.

>  include/net/netfilter/nf_conntrack.h    | 1 +
>  net/netfilter/nf_conntrack_core.c       | 4 +++-
>  net/netfilter/nf_conntrack_standalone.c | 9 +++++++++
>  3 files changed, 13 insertions(+), 1 deletion(-)

Sorry, I forgot about

Documentation/networking/nf_conntrack-sysctl.rst

Can you add a short description to that file?

I don't think anything else is missing after this.

Thanks.


  reply	other threads:[~2025-04-30  7:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 13:09 [PATCH v1] nf_conntrack: sysctl: expose gc worker scan interval via sysctl avimalin
2025-04-29 13:29 ` Florian Westphal
2025-04-30  6:43   ` [PATCH v2] " avimalin
2025-04-30  7:11     ` Florian Westphal [this message]
2025-04-30  7:28       ` [PATCH v3] " avimalin
2025-04-30  7:57         ` Florian Westphal
2025-05-03  2:27           ` Vimal Agrawal
2025-05-08  5:54             ` Vimal Agrawal
2025-10-15 13:32         ` Florian Westphal
2025-11-17 13:23           ` Vimal Agrawal
2025-11-17 14:16             ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250430071140.GA29525@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=anirudh.gupta@sophos.com \
    --cc=avimalin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=vimal.agrawal@sophos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox