The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: mcgrof@kernel.org
Cc: x86@kernel.org, hpa@zytor.com, petr.pavlu@suse.com,
	samitolvanen@google.com, da.gomez@samsung.com,
	masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kbuild@vger.kernel.org, hch@infradead.org,
	gregkh@linuxfoundation.org, roypat@amazon.co.uk,
	Sean Christopherson <seanjc@google.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: [PATCH v3 4/5] module: Account for the build time module name mangling
Date: Fri, 02 May 2025 16:12:08 +0200	[thread overview]
Message-ID: <20250502141844.263611823@infradead.org> (raw)
In-Reply-To: 20250502141204.500293812@infradead.org

Sean noted that scripts/Makefile.lib:name-fix-token rule will mangle
the module name with s/-/_/g.

Since this happens late in the build, only the kernel needs to bother
with this, the modpost tool still sees the original name.

Reported-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Sean Christopherson <seanjc@google.com>
---
 kernel/module/main.c |   26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -170,6 +170,30 @@ static inline void add_taint_module(stru
 }
 
 /*
+ * Like strncmp(), except s/-/_/g as per scripts/Makefile.lib:name-fix-token rule.
+ */
+static int mod_strncmp(const char *str_a, const char *str_b, size_t n)
+{
+	for (int i = 0; i < n; i++) {
+		char a = str_a[i];
+		char b = str_b[i];
+		int d;
+
+		if (a == '-') a = '_';
+		if (b == '-') b = '_';
+
+		d = a - b;
+		if (d)
+			return d;
+
+		if (!a)
+			break;
+	}
+
+	return 0;
+}
+
+/*
  * A thread that wants to hold a reference to a module only while it
  * is running can call this to safely exit.
  */
@@ -1116,7 +1140,7 @@ static bool verify_module_namespace(cons
 		if (*sep)
 			sep++;
 
-		if (strncmp(namespace, modname, len) == 0 && (glob || len == modlen))
+		if (mod_strncmp(namespace, modname, len) == 0 && (glob || len == modlen))
 			return true;
 	}
 



  parent reply	other threads:[~2025-05-02 14:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 14:12 [PATCH v3 0/5] module: Strict per-modname namespaces Peter Zijlstra
2025-05-02 14:12 ` [PATCH v3 1/5] modpost: Use for() loop Peter Zijlstra
2025-05-09  0:47   ` Masahiro Yamada
2025-05-02 14:12 ` [PATCH v3 2/5] module: Add module specific symbol namespace support Peter Zijlstra
2025-05-03 12:30   ` Masahiro Yamada
2025-05-14  8:34   ` Petr Pavlu
2025-05-17  6:56   ` Masahiro Yamada
2025-05-17  7:19   ` Masahiro Yamada
2025-05-22  5:31     ` Masahiro Yamada
2025-05-02 14:12 ` [PATCH v3 3/5] module: Extend the MODULE_ namespace parsing Peter Zijlstra
2025-05-14  8:35   ` Petr Pavlu
2025-05-21 12:08   ` Masahiro Yamada
2025-05-22  5:32     ` Masahiro Yamada
2025-05-02 14:12 ` Peter Zijlstra [this message]
2025-05-14  8:38   ` [PATCH v3 4/5] module: Account for the build time module name mangling Petr Pavlu
2025-05-02 14:12 ` [PATCH v3 5/5] module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper Peter Zijlstra
2025-05-14  8:40   ` Petr Pavlu
2025-05-02 14:39 ` [PATCH v3 0/5] module: Strict per-modname namespaces Greg KH
2025-05-14  8:47 ` Petr Pavlu
2025-05-17  6:48   ` Masahiro Yamada
2025-05-18 11:30     ` Petr Pavlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502141844.263611823@infradead.org \
    --to=peterz@infradead.org \
    --cc=da.gomez@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=petr.pavlu@suse.com \
    --cc=roypat@amazon.co.uk \
    --cc=samitolvanen@google.com \
    --cc=seanjc@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox