public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	Connor Abbott <cwabbott0@gmail.com>,
	Rob Clark <robdclark@chromium.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v4 01/33] drm/gpuvm: Don't require obj lock in destructor path
Date: Fri,  2 May 2025 09:56:28 -0700	[thread overview]
Message-ID: <20250502165831.44850-2-robdclark@gmail.com> (raw)
In-Reply-To: <20250502165831.44850-1-robdclark@gmail.com>

From: Rob Clark <robdclark@chromium.org>

See commit a414fe3a2129 ("drm/msm/gem: Drop obj lock in
msm_gem_free_object()") for justification.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/drm_gpuvm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index f9eb56f24bef..1e89a98caad4 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -1511,7 +1511,9 @@ drm_gpuvm_bo_destroy(struct kref *kref)
 	drm_gpuvm_bo_list_del(vm_bo, extobj, lock);
 	drm_gpuvm_bo_list_del(vm_bo, evict, lock);
 
-	drm_gem_gpuva_assert_lock_held(obj);
+	if (kref_read(&obj->refcount) > 0)
+		drm_gem_gpuva_assert_lock_held(obj);
+
 	list_del(&vm_bo->list.entry.gem);
 
 	if (ops && ops->vm_bo_free)
@@ -1871,7 +1873,8 @@ drm_gpuva_unlink(struct drm_gpuva *va)
 	if (unlikely(!obj))
 		return;
 
-	drm_gem_gpuva_assert_lock_held(obj);
+	if (kref_read(&obj->refcount) > 0)
+		drm_gem_gpuva_assert_lock_held(obj);
 	list_del_init(&va->gem.entry);
 
 	va->vm_bo = NULL;
-- 
2.49.0


  reply	other threads:[~2025-05-02 17:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 16:56 [PATCH v4 00/33] drm/msm: sparse / "VM_BIND" support Rob Clark
2025-05-02 16:56 ` Rob Clark [this message]
2025-05-02 16:56 ` [PATCH v4 02/33] drm/gpuvm: Allow VAs to hold soft reference to BOs Rob Clark
2025-05-02 16:56 ` [PATCH v4 03/33] iommu/io-pgtable-arm: Add quirk to quiet WARN_ON() Rob Clark
2025-05-02 19:29   ` ALOK TIWARI
2025-05-02 16:56 ` [PATCH v4 04/33] drm/msm: Rename msm_file_private -> msm_context Rob Clark
2025-05-02 16:56 ` [PATCH v4 05/33] drm/msm: Improve msm_context comments Rob Clark
2025-05-02 16:56 ` [PATCH v4 06/33] drm/msm: Rename msm_gem_address_space -> msm_gem_vm Rob Clark
2025-05-02 16:56 ` [PATCH v4 07/33] drm/msm: Remove vram carveout support Rob Clark
2025-05-02 16:56 ` [PATCH v4 08/33] drm/msm: Collapse vma allocation and initialization Rob Clark
2025-05-02 16:56 ` [PATCH v4 09/33] drm/msm: Collapse vma close and delete Rob Clark
2025-05-02 16:56 ` [PATCH v4 10/33] drm/msm: Don't close VMAs on purge Rob Clark
2025-05-02 16:56 ` [PATCH v4 11/33] drm/msm: drm_gpuvm conversion Rob Clark
2025-05-02 16:56 ` [PATCH v4 12/33] drm/msm: Convert vm locking Rob Clark
2025-05-02 16:56 ` [PATCH v4 13/33] drm/msm: Use drm_gpuvm types more Rob Clark
2025-05-02 16:56 ` [PATCH v4 14/33] drm/msm: Split out helper to get iommu prot flags Rob Clark
2025-05-02 16:56 ` [PATCH v4 15/33] drm/msm: Add mmu support for non-zero offset Rob Clark
2025-05-02 16:56 ` [PATCH v4 16/33] drm/msm: Add PRR support Rob Clark
2025-05-02 16:56 ` [PATCH v4 17/33] drm/msm: Rename msm_gem_vma_purge() -> _unmap() Rob Clark
2025-05-02 16:56 ` [PATCH v4 18/33] drm/msm: Lazily create context VM Rob Clark
2025-05-02 16:56 ` [PATCH v4 19/33] drm/msm: Add opt-in for VM_BIND Rob Clark
2025-05-02 16:56 ` [PATCH v4 20/33] drm/msm: Mark VM as unusable on GPU hangs Rob Clark
2025-05-02 16:56 ` [PATCH v4 21/33] drm/msm: Add _NO_SHARE flag Rob Clark
2025-05-05  7:54   ` Christian König
2025-05-05 14:15     ` Rob Clark
2025-05-05 15:17       ` Christian König
2025-05-02 16:56 ` [PATCH v4 22/33] drm/msm: Crashdump prep for sparse mappings Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502165831.44850-2-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=airlied@gmail.com \
    --cc=cwabbott0@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=robdclark@chromium.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox