[PATCH] pinctrl: at91: fix CONFIG_OF dependency

[PATCH] pinctrl: at91: fix CONFIG_OF dependency

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Selecting OF_GPIO is not allowed when CONFIG_OF is disabled:

WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - PINCTRL_AT91 [=y] && PINCTRL [=y] && (OF [=n] && ARCH_AT91 || COMPILE_TEST [=y])

WARNING: unmet direct dependencies detected for MFD_STMFX
  Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
  Selected by [y]:
  - PINCTRL_STMFX [=y] && PINCTRL [=y] && I2C [=y] && OF_GPIO [=y]

WARNING: unmet direct dependencies detected for GPIO_SYSCON
  Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF [=n]
  Selected by [y]:
  - GPIO_SAMA5D2_PIOBU [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF_GPIO [=y] && (ARCH_AT91 || COMPILE_TEST [=y])

Add back the unconditional CONFIG_OF dependency, but leave COMPILE_TEST
as an option when that is enabled.

Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index db84d80b7e7d..5d368fb66115 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -103,7 +103,8 @@ config PINCTRL_AS3722
 
 config PINCTRL_AT91
 	bool "AT91 pinctrl driver"
-	depends on (OF && ARCH_AT91) || COMPILE_TEST
+	depends on ARCH_AT91 || COMPILE_TEST
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GPIOLIB
-- 
2.39.5

Re: [PATCH] pinctrl: at91: fix CONFIG_OF dependency

[Bartosz Golaszewski]

On Fri, May 2, 2025 at 10:36 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting OF_GPIO is not allowed when CONFIG_OF is disabled:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - PINCTRL_AT91 [=y] && PINCTRL [=y] && (OF [=n] && ARCH_AT91 || COMPILE_TEST [=y])
>
> WARNING: unmet direct dependencies detected for MFD_STMFX
>   Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
>   Selected by [y]:
>   - PINCTRL_STMFX [=y] && PINCTRL [=y] && I2C [=y] && OF_GPIO [=y]
>
> WARNING: unmet direct dependencies detected for GPIO_SYSCON
>   Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF [=n]
>   Selected by [y]:
>   - GPIO_SAMA5D2_PIOBU [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF_GPIO [=y] && (ARCH_AT91 || COMPILE_TEST [=y])
>
> Add back the unconditional CONFIG_OF dependency, but leave COMPILE_TEST
> as an option when that is enabled.
>
> Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/pinctrl/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index db84d80b7e7d..5d368fb66115 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -103,7 +103,8 @@ config PINCTRL_AS3722
>
>  config PINCTRL_AT91
>         bool "AT91 pinctrl driver"
> -       depends on (OF && ARCH_AT91) || COMPILE_TEST
> +       depends on ARCH_AT91 || COMPILE_TEST
> +       depends on OF
>         select PINMUX
>         select PINCONF
>         select GPIOLIB
> --
> 2.39.5
>
>

Hi!

I sent an alternative patch[1] which simply removes the OF_GPIO
selection as this driver doesn't really need it at build-time.

Bart

[1] https://lore.kernel.org/all/20250502100841.113091-1-brgl@bgdev.pl/

Re: [PATCH] pinctrl: at91: fix CONFIG_OF dependency

[Arnd Bergmann]

On Mon, May 5, 2025, at 08:50, Bartosz Golaszewski wrote:
> On Fri, May 2, 2025 at 10:36 PM Arnd Bergmann <arnd@kernel.org> wrote:

>
> I sent an alternative patch[1] which simply removes the OF_GPIO
> selection as this driver doesn't really need it at build-time.
>
> [1] https://lore.kernel.org/all/20250502100841.113091-1-brgl@bgdev.pl/

Ok, thanks. If there is no build dependency, then that is indeed
the better fix.

     Arnd