Re: [RFT PATCH v2 05/23] x86/sev: Move instruction decoder into separate source file

Ard Biesheuvel
2025-05-05T14:50:42Z

On Mon, 5 May 2025 at 16:48, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> On 5/4/25 04:52, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@kernel.org>
> >
> > As a first step towards disentangling the SEV #VC handling code -which
> > is shared between the decompressor and the core kernel- from the SEV
> > startup code, move the decompressor's copy of the instruction decoder
> > into a separate source file.
> >
> > Code movement only - no functional change intended.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > ---
> > arch/x86/boot/compressed/Makefile | 6 +--
> > arch/x86/boot/compressed/misc.h | 7 +++
> > arch/x86/boot/compressed/sev-handle-vc.c | 51 ++++++++++++++++++++
> > arch/x86/boot/compressed/sev.c | 39 +--------------
> > 4 files changed, 62 insertions(+), 41 deletions(-)
> >
> > diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> > index 0fcad7b7e007..f4f7b22d8113 100644
> > --- a/arch/x86/boot/compressed/Makefile
> > +++ b/arch/x86/boot/compressed/Makefile
> > @@ -44,10 +44,10 @@ KBUILD_CFLAGS += -D__DISABLE_EXPORTS
> > KBUILD_CFLAGS += $(call cc-option,-Wa$(comma)-mrelax-relocations=no)
> > KBUILD_CFLAGS += -include $(srctree)/include/linux/hidden.h
> >
> > -# sev.c indirectly includes inat-table.h which is generated during
> > +# sev-decode-insn.c indirectly includes inat-table.c which is generated during
>
> did you mean sev-handle-vc.c ?
>

Ah yes - I renamed that at some point and forgot to update the comment.