The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Michael Klein <michael@fossekall.de>
To: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Michael Klein <michael@fossekall.de>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [net-next v7 5/6] net: phy: realtek: use __set_bit() in rtl8211f_led_hw_control_get()
Date: Sun,  4 May 2025 19:29:15 +0200	[thread overview]
Message-ID: <20250504172916.243185-6-michael@fossekall.de> (raw)
In-Reply-To: <20250504172916.243185-1-michael@fossekall.de>

rtl8211f_led_hw_control_get() does not need atomic bit operations,
replace set_bit() by __set_bit().

Signed-off-by: Michael Klein <michael@fossekall.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/phy/realtek/realtek_main.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c
index e01b13a9b5c3..e26098a2ff27 100644
--- a/drivers/net/phy/realtek/realtek_main.c
+++ b/drivers/net/phy/realtek/realtek_main.c
@@ -659,17 +659,17 @@ static int rtl8211f_led_hw_control_get(struct phy_device *phydev, u8 index,
 	val &= RTL8211F_LEDCR_MASK;
 
 	if (val & RTL8211F_LEDCR_LINK_10)
-		set_bit(TRIGGER_NETDEV_LINK_10, rules);
+		__set_bit(TRIGGER_NETDEV_LINK_10, rules);
 
 	if (val & RTL8211F_LEDCR_LINK_100)
-		set_bit(TRIGGER_NETDEV_LINK_100, rules);
+		__set_bit(TRIGGER_NETDEV_LINK_100, rules);
 
 	if (val & RTL8211F_LEDCR_LINK_1000)
-		set_bit(TRIGGER_NETDEV_LINK_1000, rules);
+		__set_bit(TRIGGER_NETDEV_LINK_1000, rules);
 
 	if (val & RTL8211F_LEDCR_ACT_TXRX) {
-		set_bit(TRIGGER_NETDEV_RX, rules);
-		set_bit(TRIGGER_NETDEV_TX, rules);
+		__set_bit(TRIGGER_NETDEV_RX, rules);
+		__set_bit(TRIGGER_NETDEV_TX, rules);
 	}
 
 	return 0;
-- 
2.39.5


  parent reply	other threads:[~2025-05-04 17:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-04 17:29 [net-next v7 0/6] net: phy: realtek: Add support for PHY LEDs Michael Klein
2025-05-04 17:29 ` [net-next v7 1/6] net: phy: realtek: remove unsed RTL821x_PHYSR* macros Michael Klein
2025-05-04 17:29 ` [net-next v7 2/6] net: phy: realtek: Clean up RTL821x ExtPage access Michael Klein
2025-05-05 22:05   ` Andrew Lunn
2025-05-04 17:29 ` [net-next v7 3/6] net: phy: realtek: add RTL8211F register defines Michael Klein
2025-05-05 22:06   ` Andrew Lunn
2025-05-04 17:29 ` [net-next v7 4/6] net: phy: realtek: Group RTL82* macro definitions Michael Klein
2025-05-05 22:09   ` Andrew Lunn
2025-05-04 17:29 ` Michael Klein [this message]
2025-05-04 17:29 ` [net-next v7 6/6] net: phy: realtek: Add support for PHY LEDs on RTL8211E Michael Klein
2025-05-06 11:40 ` [net-next v7 0/6] net: phy: realtek: Add support for PHY LEDs patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250504172916.243185-6-michael@fossekall.de \
    --to=michael@fossekall.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox