From: "André Apitzsch via B4 Relay" <devnull+git.apitzsch.eu@kernel.org>
To: Ricardo Ribalda <ribalda@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, "André Apitzsch" <git@apitzsch.eu>,
"Ricardo Ribalda" <ribalda@chromium.org>
Subject: [PATCH v2 1/4] media: i2c: imx214: Reorder imx214_parse_fwnode call
Date: Mon, 05 May 2025 23:05:53 +0200 [thread overview]
Message-ID: <20250505-imx214_ccs_pll-v2-1-f50452061ff1@apitzsch.eu> (raw)
In-Reply-To: <20250505-imx214_ccs_pll-v2-0-f50452061ff1@apitzsch.eu>
From: André Apitzsch <git@apitzsch.eu>
Reorder imx214_parse_fwnode call to reduce goto paths in upcoming
patches.
No functional change intended.
Acked-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/media/i2c/imx214.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index dd7bc45523d8b5fcb3ec95728a6d32c4fddede72..0199195dcb7d12dc2ff253fe3eb77ddbcd0812a9 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -1261,10 +1261,6 @@ static int imx214_probe(struct i2c_client *client)
struct imx214 *imx214;
int ret;
- ret = imx214_parse_fwnode(dev);
- if (ret)
- return ret;
-
imx214 = devm_kzalloc(dev, sizeof(*imx214), GFP_KERNEL);
if (!imx214)
return -ENOMEM;
@@ -1295,6 +1291,10 @@ static int imx214_probe(struct i2c_client *client)
return dev_err_probe(dev, PTR_ERR(imx214->regmap),
"failed to initialize CCI\n");
+ ret = imx214_parse_fwnode(dev);
+ if (ret)
+ return ret;
+
v4l2_i2c_subdev_init(&imx214->sd, client, &imx214_subdev_ops);
imx214->sd.internal_ops = &imx214_internal_ops;
--
2.49.0
next prev parent reply other threads:[~2025-05-05 21:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 21:05 [PATCH v2 0/4] media: i2c: imx214: Add support for more clock frequencies André Apitzsch via B4 Relay
2025-05-05 21:05 ` André Apitzsch via B4 Relay [this message]
2025-05-05 21:05 ` [PATCH v2 2/4] media: i2c: imx214: Prepare for variable clock frequency André Apitzsch via B4 Relay
2025-05-05 21:05 ` [PATCH v2 3/4] media: i2c: imx214: Make use of CCS PLL calculator André Apitzsch via B4 Relay
2025-05-06 8:05 ` Sakari Ailus
2025-05-06 20:16 ` André Apitzsch
2025-05-06 20:53 ` Sakari Ailus
2025-05-05 21:05 ` [PATCH v2 4/4] media: i2c: imx214: Remove hard-coded external clock frequency André Apitzsch via B4 Relay
2025-05-06 8:24 ` Sakari Ailus
2025-05-14 6:46 ` André Apitzsch
2025-05-15 8:58 ` Laurent Pinchart
2025-05-15 11:54 ` Sakari Ailus
2025-05-15 13:03 ` Laurent Pinchart
2025-05-15 21:02 ` Sakari Ailus
2025-05-15 21:21 ` André Apitzsch
2025-05-21 16:50 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505-imx214_ccs_pll-v2-1-f50452061ff1@apitzsch.eu \
--to=devnull+git.apitzsch.eu@kernel.org \
--cc=git@apitzsch.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=ribalda@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).