public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 10/13] tracing: branch: Use trace_tracing_is_on_cpu() instead of "disabled" field
Date: Mon, 05 May 2025 17:21:14 -0400	[thread overview]
Message-ID: <20250505212236.224658526@goodmis.org> (raw)
In-Reply-To: 20250505212104.986494754@goodmis.org

From: Steven Rostedt <rostedt@goodmis.org>

The branch tracer currently checks the per CPU "disabled" field to know if
tracing is enabled or not for the CPU. As the "disabled" value is not used
anymore to turn of tracing generically, use tracing_tracer_is_on_cpu()
instead.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Changes since v1: https://lore.kernel.org/20250502205349.299144667@goodmis.org

- Fixed "raw_smp_process_id()" to "raw_smp_processor_id()"
  (kernel test robot)

 kernel/trace/trace_branch.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index 6d08a5523ce0..6809b370e991 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -32,7 +32,6 @@ probe_likely_condition(struct ftrace_likely_data *f, int val, int expect)
 {
 	struct trace_array *tr = branch_tracer;
 	struct trace_buffer *buffer;
-	struct trace_array_cpu *data;
 	struct ring_buffer_event *event;
 	struct trace_branch *entry;
 	unsigned long flags;
@@ -54,8 +53,7 @@ probe_likely_condition(struct ftrace_likely_data *f, int val, int expect)
 
 	raw_local_irq_save(flags);
 	current->trace_recursion |= TRACE_BRANCH_BIT;
-	data = this_cpu_ptr(tr->array_buffer.data);
-	if (atomic_read(&data->disabled))
+	if (!tracer_tracing_is_on_cpu(tr, raw_smp_processor_id()))
 		goto out;
 
 	trace_ctx = tracing_gen_ctx_flags(flags);
-- 
2.47.2



  parent reply	other threads:[~2025-05-05 21:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 21:21 [PATCH v2 00/13] tracing: Remove most uses of "disabled" field Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 01/13] tracing/mmiotrace: Remove reference to unused per CPU data pointer Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 02/13] ftrace: Do not bother checking per CPU "disabled" flag Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 03/13] tracing: Just use this_cpu_read() to access ignore_pid Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 04/13] tracing: Add tracer_tracing_disable/enable() functions Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 05/13] tracing: Use tracer_tracing_disable() instead of "disabled" field for ftrace_dump_one() Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 06/13] tracing: kdb: Use tracer_tracing_on/off() instead of setting per CPU disabled Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 07/13] ftrace: Do not disabled function graph based on "disabled" field Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 08/13] tracing: Do not use per CPU array_buffer.data->disabled for cpumask Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 09/13] ring-buffer: Add ring_buffer_record_is_on_cpu() Steven Rostedt
2025-05-05 21:21 ` Steven Rostedt [this message]
2025-05-05 21:21 ` [PATCH v2 11/13] tracing: Convert the per CPU "disabled" counter to local from atomic Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 12/13] tracing: Use atomic_inc_return() for updating "disabled" counter in irqsoff tracer Steven Rostedt
2025-05-05 21:21 ` [PATCH v2 13/13] tracing: Remove unused buffer_page field from trace_array_cpu structure Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250505212236.224658526@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox