From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 293231D8E10; Mon, 5 May 2025 22:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483834; cv=none; b=gA7E/tWu09q87sQk8hHnwKyHa0xAkHrVhGt/72qE1cXFYtstiox3CKbeMiQUk8nnW6KPNGhjX7ayyZler8rOFLxj7ZtiSIAu8/8KhoJ6CB5GeHxV+m7Bc0ZyOl1NSZz5aZqki7iC1BHNU/seP65Mpv4yZdVScng9h66iYUCClqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483834; c=relaxed/simple; bh=L12TfLyhSgJ8CCXsimdHeqgPD24pWLgJegt2ic6cTG0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aOFC+NRTBrQ/rh6avUCO4utenkeL1mlwddkq8LU65YVANuSFVpIxJQ5NAxA9sU71nzfN2ATLxFrxd+07umLaUoQvgqCb9n2JV7M7BE5/O70Q4BAYyMV5A8pBEQzqMaCDz0Vwo/d/pvy3tAhGEzIHXb780rGoLIX3eZasvANJ3TY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lGBTSN+u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lGBTSN+u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F896C4CEF1; Mon, 5 May 2025 22:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746483834; bh=L12TfLyhSgJ8CCXsimdHeqgPD24pWLgJegt2ic6cTG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lGBTSN+uTNueJVtlVIuEx4ZQmwsLmN4zPAodloG6EpyzM4AipA/oBVpl57ZHGFwrx gC1BKAmCMs5pRJ9HOCnST4c9g32pvYHOD6+4Qx7q3Zus8ce6vOfIriXCShwL5MP11p CJr93iWTpSkGbM7Zw4OKQwG2VCMrJ4C9JQOvfBfei4Vag7jMkKNAfxY3vlhXy6plLx 5JHkocJO0+4SOi4YN3yQ+r/bTUCv7nUpjMEJBlt3YHrsFuoiiPyTYjBqESWkb2hinH urFnOOIK8q9HF1UzMQGDMhzPbshkQTw5Dv9TIw6/oUSOagOB3grSgEOxl+ti288Hrv 1Xh9uxbPkrQaw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Choong Yong Liang , Russell King , Jakub Kicinski , Sasha Levin , linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 242/642] net: phylink: use pl->link_interface in phylink_expects_phy() Date: Mon, 5 May 2025 18:07:38 -0400 Message-Id: <20250505221419.2672473-242-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505221419.2672473-1-sashal@kernel.org> References: <20250505221419.2672473-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.5 Content-Transfer-Encoding: 8bit From: Choong Yong Liang [ Upstream commit b63263555eaafbf9ab1a82f2020bbee872d83759 ] The phylink_expects_phy() function allows MAC drivers to check if they are expecting a PHY to attach. The checking condition in phylink_expects_phy() aims to achieve the same result as the checking condition in phylink_attach_phy(). However, the checking condition in phylink_expects_phy() uses pl->link_config.interface, while phylink_attach_phy() uses pl->link_interface. Initially, both pl->link_interface and pl->link_config.interface are set to SGMII, and pl->cfg_link_an_mode is set to MLO_AN_INBAND. When the interface switches from SGMII to 2500BASE-X, pl->link_config.interface is updated by phylink_major_config(). At this point, pl->cfg_link_an_mode remains MLO_AN_INBAND, and pl->link_config.interface is set to 2500BASE-X. Subsequently, when the STMMAC interface is taken down administratively and brought back up, it is blocked by phylink_expects_phy(). Since phylink_expects_phy() and phylink_attach_phy() aim to achieve the same result, phylink_expects_phy() should check pl->link_interface, which never changes, instead of pl->link_config.interface, which is updated by phylink_major_config(). Reviewed-by: Russell King (Oracle) Signed-off-by: Choong Yong Liang Link: https://patch.msgid.link/20250227121522.1802832-2-yong.liang.choong@linux.intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 5be48eb810abb..8c4dfe9dc7650 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -2074,7 +2074,7 @@ bool phylink_expects_phy(struct phylink *pl) { if (pl->cfg_link_an_mode == MLO_AN_FIXED || (pl->cfg_link_an_mode == MLO_AN_INBAND && - phy_interface_mode_is_8023z(pl->link_config.interface))) + phy_interface_mode_is_8023z(pl->link_interface))) return false; return true; } -- 2.39.5