From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115E52857FF; Mon, 5 May 2025 22:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483950; cv=none; b=T+DEmX07FxvBVhqcZL20rRIqF+Fo0cZAoZT0wEAiQztxvcqnGR9tO1iZiu6RLN3oMj5VvaMSmAR8M6FRR8U49gCThQGyv+warMdv8rk9iG33/qOn0C5d2hd1EhrzIEsJOOSRqczegVs6ZXqlexNF2gcxsqC3Y/jVAtHtC3KK7z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746483950; c=relaxed/simple; bh=QB5BDmNQRFBOKORRB1IUyzjlT4+1l2j7PdDoCOiaFtk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Za64WMVS9L4dniVZ6sYItmV3GgHZASfqWdlpVkkAfQlNVHj34ccl0RSqz3/b839qAGvQZNiJl8uAzM8uCYf4hBPzpvHK2J7zODl95zord4z6TGTJzM/Qeg9Bi1k8zsRb0WnonJpVoOTAelaZio93w6PpBrTNA+7f7OAtpLe0wh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qV05W9VH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qV05W9VH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD214C4CEEE; Mon, 5 May 2025 22:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746483949; bh=QB5BDmNQRFBOKORRB1IUyzjlT4+1l2j7PdDoCOiaFtk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qV05W9VHoskYMZHm/Cmbi5JUejbcZ4eRls4ldG7+Womh2/XACUGNOHzZJpXQlgXTw +I48/w2SdyugDyFHOs237esjS9XB7oes5LOGUzuoxRBAfQl+AIuBR8Iqvw8WNW48Fx yAtBsQNQS5zxZytKHQdl0B6hWqLBeBsWzJu2SIKTfApcgcqC07isddG8XcK+p5lq2D teeKuMWXogQA6i7J/37/SLQSyICrD9g34tbSl0KaebHsc00AhksKvTim7Fy/S/EYhf 6tQztz1VVikBB1KKR3Wc3KUdKigYo0ifpbn7QWtBmWCBAFwOPtFvQ55b+5O7NrYIrX NuDOooxF/ay4g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Stein , Guenter Roeck , Sasha Levin , jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 285/642] hwmon: (gpio-fan) Add missing mutex locks Date: Mon, 5 May 2025 18:08:21 -0400 Message-Id: <20250505221419.2672473-285-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505221419.2672473-1-sashal@kernel.org> References: <20250505221419.2672473-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.5 Content-Transfer-Encoding: 8bit From: Alexander Stein [ Upstream commit 9fee7d19bab635f89223cc40dfd2c8797fdc4988 ] set_fan_speed() is expected to be called with fan_data->lock being locked. Add locking for proper synchronization. Signed-off-by: Alexander Stein Link: https://lore.kernel.org/r/20250210145934.761280-3-alexander.stein@ew.tq-group.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/gpio-fan.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index d92c536be9af7..b779240328d59 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -393,7 +393,12 @@ static int gpio_fan_set_cur_state(struct thermal_cooling_device *cdev, if (state >= fan_data->num_speed) return -EINVAL; + mutex_lock(&fan_data->lock); + set_fan_speed(fan_data, state); + + mutex_unlock(&fan_data->lock); + return 0; } @@ -489,7 +494,11 @@ MODULE_DEVICE_TABLE(of, of_gpio_fan_match); static void gpio_fan_stop(void *data) { + struct gpio_fan_data *fan_data = data; + + mutex_lock(&fan_data->lock); set_fan_speed(data, 0); + mutex_unlock(&fan_data->lock); } static int gpio_fan_probe(struct platform_device *pdev) @@ -562,7 +571,9 @@ static int gpio_fan_suspend(struct device *dev) if (fan_data->gpios) { fan_data->resume_speed = fan_data->speed_index; + mutex_lock(&fan_data->lock); set_fan_speed(fan_data, 0); + mutex_unlock(&fan_data->lock); } return 0; @@ -572,8 +583,11 @@ static int gpio_fan_resume(struct device *dev) { struct gpio_fan_data *fan_data = dev_get_drvdata(dev); - if (fan_data->gpios) + if (fan_data->gpios) { + mutex_lock(&fan_data->lock); set_fan_speed(fan_data, fan_data->resume_speed); + mutex_unlock(&fan_data->lock); + } return 0; } -- 2.39.5