From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 525FD32E4EE; Mon, 5 May 2025 22:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746484530; cv=none; b=DW+ahK5gUGxkzK6VuaDSzsr+SxI+WSFF30bipDep3+DCq58qO+SMyK4d388fIedGAnyCN7K7kDUglJz5rHgfXXkbzzouAIXFmdL8xNl/qLsCMhykENd5XuBwTkCbZ/23s6dZjGkNrXSpWvM1FFhkKYKrUdjgwjqVpddx+VkpdY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746484530; c=relaxed/simple; bh=Sv3jcJ41kGgD+i5aNCLFTE9CZvvFV4IcNMYPPtRqCEg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WeA6Daqlqkxnib215/HON8ejhOD/++rIJslnbpWhAdzDXjGqYGEBvx6V5YMS8i/OEzWvqzbPYIgPmarBstr9l4/WT+hIEf+F/XvvaOYySziJ4/0fxMXodbsyk9ZpgwRhD46REdnYvm1yrlxytgc8XDrp205TXx3M/jA9DgQzvAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r7CibCe4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r7CibCe4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6329C4CEE4; Mon, 5 May 2025 22:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746484529; bh=Sv3jcJ41kGgD+i5aNCLFTE9CZvvFV4IcNMYPPtRqCEg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r7CibCe4CRX7mkPgJCWn4wdiZeDTk5VG8YMnhAcTfQE2J7hI2BZEXASRVYT74zE5Q KYKiTwI/zJWc302OzRazlC0pB8Vt4e/kw9SXkmuO70Q50+QRjasix0tBqjCff5Ps2O zDeVyWFTStvqOn5s9hwbjKqafNdMdMUGtbbadjl4xxR60u/UpclmIr1bGY7GQGPrzR Zb/XMNjAKuvQAvA/pfOqmD6J7S8JT3C8HoMdaT8PnC/oNbirPxj4ORbhc5F3VMCXKx +A7O5Qw8uNByWbfTjiUaad61uCns7e2ghuP09D3q88NJyFF4GgRNAui5qliXFM8HRc AYBsrPh/f/zDQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Marek Vasut , Lee Jones , Sasha Levin , pavel@kernel.org, andrew@lunn.ch, lukma@denx.de, linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 6.14 517/642] leds: trigger: netdev: Configure LED blink interval for HW offload Date: Mon, 5 May 2025 18:12:13 -0400 Message-Id: <20250505221419.2672473-517-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505221419.2672473-1-sashal@kernel.org> References: <20250505221419.2672473-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.5 Content-Transfer-Encoding: 8bit From: Marek Vasut [ Upstream commit c629c972b310af41e9e072febb6dae9a299edde6 ] In case a PHY LED implements .blink_set callback to set LED blink interval, call it even if .hw_control is already set, as that LED blink interval likely controls the blink rate of that HW offloaded LED. For PHY LEDs, that can be their activity blinking interval. The software blinking is not affected by this change. With this change, the LED interval setting looks something like this: $ echo netdev > /sys/class/leds/led:green:lan/trigger $ echo 1 > /sys/class/leds/led:green:lan/brightness $ echo 250 > /sys/class/leds/led:green:lan/interval Signed-off-by: Marek Vasut Link: https://lore.kernel.org/r/20250120113740.91807-1-marex@denx.de Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/leds/trigger/ledtrig-netdev.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index c15efe3e50780..4e048e08c4fde 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -68,6 +68,7 @@ struct led_netdev_data { unsigned int last_activity; unsigned long mode; + unsigned long blink_delay; int link_speed; __ETHTOOL_DECLARE_LINK_MODE_MASK(supported_link_modes); u8 duplex; @@ -86,6 +87,10 @@ static void set_baseline_state(struct led_netdev_data *trigger_data) /* Already validated, hw control is possible with the requested mode */ if (trigger_data->hw_control) { led_cdev->hw_control_set(led_cdev, trigger_data->mode); + if (led_cdev->blink_set) { + led_cdev->blink_set(led_cdev, &trigger_data->blink_delay, + &trigger_data->blink_delay); + } return; } @@ -454,10 +459,11 @@ static ssize_t interval_store(struct device *dev, size_t size) { struct led_netdev_data *trigger_data = led_trigger_get_drvdata(dev); + struct led_classdev *led_cdev = trigger_data->led_cdev; unsigned long value; int ret; - if (trigger_data->hw_control) + if (trigger_data->hw_control && !led_cdev->blink_set) return -EINVAL; ret = kstrtoul(buf, 0, &value); @@ -466,9 +472,13 @@ static ssize_t interval_store(struct device *dev, /* impose some basic bounds on the timer interval */ if (value >= 5 && value <= 10000) { - cancel_delayed_work_sync(&trigger_data->work); + if (trigger_data->hw_control) { + trigger_data->blink_delay = value; + } else { + cancel_delayed_work_sync(&trigger_data->work); - atomic_set(&trigger_data->interval, msecs_to_jiffies(value)); + atomic_set(&trigger_data->interval, msecs_to_jiffies(value)); + } set_baseline_state(trigger_data); /* resets timer */ } -- 2.39.5