From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0ABF281537; Mon, 5 May 2025 23:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486351; cv=none; b=f9lhFdYeGZQ728pme8IlmtY7llRzwI0p182YMpB6e9e1YJx9E+Pdtl3ahnVIxc5WwNKGLbHNxnnVH/EP6eaeJxVOMz+y4Pjl0ZRgJETPIkjUrFFaysPfx5aicptZwtrwNKEoXGh/wTZr6cs4ubfIu50/waevQO7flUWTk0aBtfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746486351; c=relaxed/simple; bh=xnvKQSgmz6+WJmoTJIO0JKQ6WIu8i0r+uXotJHnnevk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K8CoVQz86NFxpwr6NwXcWtjy07BYsqYL8c5vNGvQlKz4v5JFIs0vq10Kwdp95GOt7DWTDIwdVgkwDFFYFuwdzKhxxpr25QooUtLOL1Ego7tG2Kp8QTbT04ZAPORXfxqVbGYSMaH6kSpX0lhxrqUvC8TAf8wHEmcRsRIWuw25J6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uZqivO3p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uZqivO3p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63B76C4CEF1; Mon, 5 May 2025 23:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746486350; bh=xnvKQSgmz6+WJmoTJIO0JKQ6WIu8i0r+uXotJHnnevk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uZqivO3pM0aI2DXBcxSZ09FbTyl6LRflCQdVegU9H9S0IQuPS5YNNR4e8pelON2/A bE574aB3fT2KVnLm6mvtXvyNtj52DKUGEeTNNOuWn1SUmaspJ9xEPup51qiD3i/Uff TNQVidZu7FpdPVMl05ZMMfwjbXn9Q72dVTPRDT6uo3F3t8/PfZ7foRwxf4Uh7kXkeN 21UdszTwn8wqf1YyyZxMmJ3FF1BIiJNaUvUqzIxOnWOfJH04AegXxSQFfIJrxZ6BZv aixJWvKJvpuf6S3CQ+kO1cfOTLPOWbiaiuKthbXbthgWjW0LwK6eb+CrG6f+bQTdij V/uAjMVK9+quQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cezary Rojewski , Mark Brown , Sasha Levin , shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 274/294] ASoC: codecs: pcm3168a: Allow for 24-bit in provider mode Date: Mon, 5 May 2025 18:56:14 -0400 Message-Id: <20250505225634.2688578-274-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505225634.2688578-1-sashal@kernel.org> References: <20250505225634.2688578-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.89 Content-Transfer-Encoding: 8bit From: Cezary Rojewski [ Upstream commit 7d92a38d67e5d937b64b20aa4fd14451ee1772f3 ] As per codec device specification, 24-bit is allowed in provider mode. Update the code to reflect that. Signed-off-by: Cezary Rojewski Link: https://patch.msgid.link/20250203141051.2361323-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/pcm3168a.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 9d6431338fb71..329549936bd5c 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -494,9 +494,9 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream, } break; case 24: - if (provider_mode || (format == SND_SOC_DAIFMT_DSP_A) || - (format == SND_SOC_DAIFMT_DSP_B)) { - dev_err(component->dev, "24-bit slots not supported in provider mode, or consumer mode using DSP\n"); + if (!provider_mode && ((format == SND_SOC_DAIFMT_DSP_A) || + (format == SND_SOC_DAIFMT_DSP_B))) { + dev_err(component->dev, "24-bit slots not supported in consumer mode using DSP\n"); return -EINVAL; } break; -- 2.39.5