From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBC6B2F819B; Mon, 5 May 2025 23:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487203; cv=none; b=XBRGIO6AEUr8wdse/Vx1abOun48ZbIbzqJl4u9C8K6rW62+XZcTHQl2cfc7+WnInlhYTwCwKAGWf83I5XdTsInUVwXZ0AryKyZT38dko5n8slE2AuiVWFOtwEnKIJQs7TOGU92jJL1kZPaCoUdFbUOQV4ppj4K2XPDu1pDhyXro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487203; c=relaxed/simple; bh=CSJhOkzkiduu5ndm2PmYWC0q7Oa4idlGlQu8exG6sBI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YaXPlNfYilo9pOgKLsStVkdVmF6TPgdAcjo4egh9MAXT+Sc/z2gkK6dxil3IFfu7mdYIO4bCULK6fNB4stvkUocnrF0AWJPyOGi+Vdzn5mw2TIXfIzhqw/9MXX6iuSnrbLdkUcWyQ8yWjOO4OLwsJ8CBUWVfeGpkwHaOlGBbGB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fxjCyFOb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fxjCyFOb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6790C4CEED; Mon, 5 May 2025 23:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487201; bh=CSJhOkzkiduu5ndm2PmYWC0q7Oa4idlGlQu8exG6sBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fxjCyFObtKAjbOTKnX2D2bzwNojQG5sX/fTx7HBTC79sa+VR2dN4wvLeU+kRAebuD bVShm3hvCPy2TLCW3c6rqb6uw+e8t6YR/IHzlU8TsVIWS1cKLagS3ik6PMIZ4s0LMa 5hPbS+6R15NNk9g5xKZY8V9DcDlegNx22CL5CIUlMhTn3R6DCoiPlPvmeuD3f/mCUX aXuSf/r3No/v0fq900Pu2NBf8+/LmTN13X0ab3ekWH5nP52/YX0XxD/QL9rt7wctu7 e7fRJRm05HMOUik2EfvmrnDNN+PLfqJFdRLTjyDBvyvELYLWrEaIqk1Dtb4OU65HrL wTMeywqNQw7kg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Stein , Guenter Roeck , Sasha Levin , jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 054/114] hwmon: (gpio-fan) Add missing mutex locks Date: Mon, 5 May 2025 19:17:17 -0400 Message-Id: <20250505231817.2697367-54-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231817.2697367-1-sashal@kernel.org> References: <20250505231817.2697367-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.237 Content-Transfer-Encoding: 8bit From: Alexander Stein [ Upstream commit 9fee7d19bab635f89223cc40dfd2c8797fdc4988 ] set_fan_speed() is expected to be called with fan_data->lock being locked. Add locking for proper synchronization. Signed-off-by: Alexander Stein Link: https://lore.kernel.org/r/20250210145934.761280-3-alexander.stein@ew.tq-group.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/gpio-fan.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index d96e435cc42b1..e0b3917dfe6f9 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -394,7 +394,12 @@ static int gpio_fan_set_cur_state(struct thermal_cooling_device *cdev, if (state >= fan_data->num_speed) return -EINVAL; + mutex_lock(&fan_data->lock); + set_fan_speed(fan_data, state); + + mutex_unlock(&fan_data->lock); + return 0; } @@ -490,7 +495,11 @@ MODULE_DEVICE_TABLE(of, of_gpio_fan_match); static void gpio_fan_stop(void *data) { + struct gpio_fan_data *fan_data = data; + + mutex_lock(&fan_data->lock); set_fan_speed(data, 0); + mutex_unlock(&fan_data->lock); } static int gpio_fan_probe(struct platform_device *pdev) @@ -564,7 +573,9 @@ static int gpio_fan_suspend(struct device *dev) if (fan_data->gpios) { fan_data->resume_speed = fan_data->speed_index; + mutex_lock(&fan_data->lock); set_fan_speed(fan_data, 0); + mutex_unlock(&fan_data->lock); } return 0; @@ -574,8 +585,11 @@ static int gpio_fan_resume(struct device *dev) { struct gpio_fan_data *fan_data = dev_get_drvdata(dev); - if (fan_data->gpios) + if (fan_data->gpios) { + mutex_lock(&fan_data->lock); set_fan_speed(fan_data, fan_data->resume_speed); + mutex_unlock(&fan_data->lock); + } return 0; } -- 2.39.5