From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 154773B11FB; Mon, 5 May 2025 23:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487236; cv=none; b=sKimFDvZDzr0ELNUY7qk1bZmYCGqmBNVI6J1Zqg+guT8IRnIPmn2nsjXc21I3anLGeW1lzf/PcpIy1pu8dTy7QgBryeXbRW7hMcToL65yNc17IQ/fcCdirv/2diuCWvO+YnVx/5ZgQfwaYqZQk5dFcrrO8SbHLx4Ko6/LKgjBo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487236; c=relaxed/simple; bh=D2onoH0eioFutunK8t49CfkAwg7YCy58FHYrZHRgwp0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=IMF/+qx2AQo12tQ+mAXiKY7vj6dMgpSR7o3X+Foc8maWlsRiNt/nPzrxwe8qYUlJyQD6Ba0ihzTYA+qO12paYmrLNI7/KrwCO0HakPNlDfS3idIh3foD7W7l4KMgVMA/al+Dixv9ebOvarJz0OhOq0UNHA35BM0sBWOs72REjBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VxuTRzMv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VxuTRzMv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B40C4CEEF; Mon, 5 May 2025 23:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487234; bh=D2onoH0eioFutunK8t49CfkAwg7YCy58FHYrZHRgwp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VxuTRzMvoiAJDY2SKTCpWhDifhJovH+lHZmYHqX8IXpvVtAN/l3YhGJaNcnsn8SUW o0OJbq9Br7iEI5SNj5hT1tM+j9A1x2I8h2psoDhPyZrgFr/cp1sQhiAJuqDSFbNn1o +uTB3kruLlIfphN/OjnIs5s90vgO4NJhaBn2KOLsGkVUUc/+4s8/8uZfmdkXLs+FQT 4rtHIv8jw5tazKyl1SZVt1X8AgWfDPsGF1AE6aNgGbpaJ9CeJwmLRQDOVYxlhWuDAd EMIFq0CAaJnmNdWQ1+WPAdGwu5NhMxYPJqIniVOnV5XYJMoXh/MOhkOJEg5chtZ+IO wX9+toOHxEB9Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Paul Burton , Chao-ying Fu , Dragan Mladjenovic , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Serge Semin , Gregory CLEMENT , Daniel Lezcano , Thomas Bogendoerfer , Sasha Levin , tglx@linutronix.de, linux-mips@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 070/114] clocksource: mips-gic-timer: Enable counter when CPUs start Date: Mon, 5 May 2025 19:17:33 -0400 Message-Id: <20250505231817.2697367-70-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505231817.2697367-1-sashal@kernel.org> References: <20250505231817.2697367-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.237 Content-Transfer-Encoding: 8bit From: Paul Burton [ Upstream commit 3128b0a2e0cf6e07aa78e5f8cf7dd9cd59dc8174 ] In multi-cluster MIPS I6500 systems there is a GIC in each cluster, each with its own counter. When a cluster powers up the counter will be stopped, with the COUNTSTOP bit set in the GIC_CONFIG register. In single cluster systems, it has been fine to clear COUNTSTOP once in gic_clocksource_of_init() to start the counter. In multi-cluster systems, this will only have started the counter in the boot cluster, and any CPUs in other clusters will find their counter stopped which will break the GIC clock_event_device. Resolve this by having CPUs clear the COUNTSTOP bit when they come online, using the existing gic_starting_cpu() CPU hotplug callback. This will allow CPUs in secondary clusters to ensure that the cluster's GIC counter is running as expected. Signed-off-by: Paul Burton Signed-off-by: Chao-ying Fu Signed-off-by: Dragan Mladjenovic Signed-off-by: Aleksandar Rikalo Reviewed-by: Philippe Mathieu-Daudé Tested-by: Serge Semin Tested-by: Gregory CLEMENT Acked-by: Daniel Lezcano Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- drivers/clocksource/mips-gic-timer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c index be4175f415ba5..1946691f6b322 100644 --- a/drivers/clocksource/mips-gic-timer.c +++ b/drivers/clocksource/mips-gic-timer.c @@ -119,6 +119,9 @@ static void gic_update_frequency(void *data) static int gic_starting_cpu(unsigned int cpu) { + /* Ensure the GIC counter is running */ + clear_gic_config(GIC_CONFIG_COUNTSTOP); + gic_clockevent_cpu_init(cpu, this_cpu_ptr(&gic_clockevent_device)); return 0; } @@ -253,9 +256,6 @@ static int __init gic_clocksource_of_init(struct device_node *node) pr_warn("Unable to register clock notifier\n"); } - /* And finally start the counter */ - clear_gic_config(GIC_CONFIG_COUNTSTOP); - /* * It's safe to use the MIPS GIC timer as a sched clock source only if * its ticks are stable, which is true on either the platforms with -- 2.39.5