From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519942FA7F9; Mon, 5 May 2025 23:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487382; cv=none; b=E4YaCLGaT7+1O2JAgdws/quHD8sJBOMOsZK3zTI+Vb3R49YaKQ3t7bmb+QQC5P7jLdJsHzcMYzZ6T1t8qJl9yCF64KknlNfstNrOImSlNDjOVeFrOBJj/zcpZ6UWRJNH2ERm7wGtOFR/RqE9MSgggBTJx2kioHWF85aXbqsKa3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487382; c=relaxed/simple; bh=9Ys7afrd71WE0czUqk3Z040B9YIQFITKH1LoDScPqSY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NiR9pm8tTKK8ZWmLHqcne1wi5lLRbZG/V9vDkGWdlk/umF1jguwCSMzCUxcv5vPja7eQJY7UQ5HuBN9mqyj6F5pCCd0f2Gi3fGgGSDkifzmfpfsJsZZ0ApIQk7JFQfTIITaZ3fNzaEquCxdf9fpMeCPlYBmSdtuvI94ITNAfsbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WadDTc1F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WadDTc1F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9ADCC4CEEF; Mon, 5 May 2025 23:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487381; bh=9Ys7afrd71WE0czUqk3Z040B9YIQFITKH1LoDScPqSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WadDTc1FHKj8phqxJF8gW8he8WUQcICY5lML9v5OPUh1pGXqQkV0DWWGD1NidrCMj DQQYKcRr4CBHPBqtvWl5lMbePb4nvSaMJ22K9VDswSygsHwbuIAdqnO9GHs4todV5m 7tLXyZZhuBY5HEUFVSMgFFkqZ0QZJBw2NUfUsbNz3h1ASnv2Vsc4ARSaf95ysMRykC jWK0Kg0fPrwal7pgL+RGRw59KoJy0plCwiffY2xkhF9Qf/ZTGfDqWm7xym5WwsSVwC fuinfwwXgwuwyPZuLRLAmu5c7hvAUXd5ISkBbxZpSsyxWuvfPhebsw8+OTXXnD5hUq kP1VUMXckXJ4w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: AngeloGioacchino Del Regno , CK Hu , Chun-Kuang Hu , Sasha Levin , p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, matthias.bgg@gmail.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 39/79] drm/mediatek: mtk_dpi: Add checks for reg_h_fre_con existence Date: Mon, 5 May 2025 19:21:11 -0400 Message-Id: <20250505232151.2698893-39-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505232151.2698893-1-sashal@kernel.org> References: <20250505232151.2698893-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.293 Content-Transfer-Encoding: 8bit From: AngeloGioacchino Del Regno [ Upstream commit 8c9da7cd0bbcc90ab444454fecf535320456a312 ] In preparation for adding support for newer DPI instances which do support direct-pin but do not have any H_FRE_CON register, like the one found in MT8195 and MT8188, add a branch to check if the reg_h_fre_con variable was declared in the mtk_dpi_conf structure for the probed SoC DPI version. As a note, this is useful specifically only for cases in which the support_direct_pin variable is true, so mt8195-dpintf is not affected by any issue. Reviewed-by: CK Hu Signed-off-by: AngeloGioacchino Del Regno Link: https://patchwork.kernel.org/project/dri-devel/patch/20250217154836.108895-6-angelogioacchino.delregno@collabora.com/ Signed-off-by: Chun-Kuang Hu Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 191e0cec004b4..6d105e8aae459 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -337,12 +337,13 @@ static void mtk_dpi_config_swap_input(struct mtk_dpi *dpi, bool enable) static void mtk_dpi_config_2n_h_fre(struct mtk_dpi *dpi) { - mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, H_FRE_2N, H_FRE_2N); + if (dpi->conf->reg_h_fre_con) + mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, H_FRE_2N, H_FRE_2N); } static void mtk_dpi_config_disable_edge(struct mtk_dpi *dpi) { - if (dpi->conf->edge_sel_en) + if (dpi->conf->edge_sel_en && dpi->conf->reg_h_fre_con) mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, 0, EDGE_SEL_EN); } -- 2.39.5