From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C0D2385422; Mon, 5 May 2025 23:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487428; cv=none; b=AZGrsIEOAlY1lTiJgblzVpumb+oAk8cTV3gJ8x1uwFDK/qIgGZyHkrtuTmeOQong51vBeX4yOhN2/iCZrwOHdMzA1ShSBnwIpY/IV+Nqy04YHwFJAU2xVYA62HqGtJ1kkmIGiuafw7SzZW1MuzylrNCEWzS9Iu0Xwfl7iUEkyn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746487428; c=relaxed/simple; bh=qFWqH2m4VdVUeXk8WYPLlL0rQMwt65e+mgnXxmQ7TNY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sspoTavHOLYhhnJ9MxBpqDvuT3N/FWz1FDQHw9b+Cxc2qT2W8owZ+PfVbDCXOAPlSPUfEMg6Z4Y6t/bLVNtVV4OsoEcgSa8+Ph9qZTFNEXSGKi60h0J6/7ZJbfxhCINnyG0S4KELLAq9GLgPrPq6uJIK3Mfa7ToSjKLHIhvkjZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ct7kUO2G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ct7kUO2G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 651DBC4CEE4; Mon, 5 May 2025 23:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746487426; bh=qFWqH2m4VdVUeXk8WYPLlL0rQMwt65e+mgnXxmQ7TNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ct7kUO2Ge6xi8HCOA++9VVhG8cLZfSRbTLlX/Jzh3asI2nBFi/opkTzv7EEri+7u1 /ISac8tUmVvdEGog2uW15NsnKaxDLj8fZhNXeAPWTbDHWwzwul8YYCXNfZuacf2CHq c8ovEk0QuW13SA26zk6+Sm9g7V+ICPfAqz4WCtQSxIwpTvigqYDbRyQZ8rx8wP11/b fxvgrQoV6KmJQPwOGAOkhO0L0iB0y2G7Eoq0F5Z0lhUozLAoIlWQXQLmGRdTIpqFPv cQojLnxvW1kIdTSIWGElV+hj5HFS2AIpZzE7NmRvKpGwh4mAFUBOjkaq0lBUGJ2Iv6 B1fQmq7/TWf4A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kuniyuki Iwashima , Eric Dumazet , Ido Schimmel , Jakub Kicinski , Sasha Levin , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 65/79] ip: fib_rules: Fetch net from fib_rule in fib[46]_rule_configure(). Date: Mon, 5 May 2025 19:21:37 -0400 Message-Id: <20250505232151.2698893-65-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505232151.2698893-1-sashal@kernel.org> References: <20250505232151.2698893-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.293 Content-Transfer-Encoding: 8bit From: Kuniyuki Iwashima [ Upstream commit 5a1ccffd30a08f5a2428cd5fbb3ab03e8eb6c66d ] The following patch will not set skb->sk from VRF path. Let's fetch net from fib_rule->fr_net instead of sock_net(skb->sk) in fib[46]_rule_configure(). Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Link: https://patch.msgid.link/20250207072502.87775-5-kuniyu@amazon.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv4/fib_rules.c | 4 ++-- net/ipv6/fib6_rules.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index e9a3cc9e98dfa..1617ea18fae3a 100644 --- a/net/ipv4/fib_rules.c +++ b/net/ipv4/fib_rules.c @@ -220,9 +220,9 @@ static int fib4_rule_configure(struct fib_rule *rule, struct sk_buff *skb, struct nlattr **tb, struct netlink_ext_ack *extack) { - struct net *net = sock_net(skb->sk); + struct fib4_rule *rule4 = (struct fib4_rule *)rule; + struct net *net = rule->fr_net; int err = -EINVAL; - struct fib4_rule *rule4 = (struct fib4_rule *) rule; if (frh->tos & ~IPTOS_TOS_MASK) { NL_SET_ERR_MSG(extack, "Invalid tos"); diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c index 3cf9dc2231036..acb8610c9a9df 100644 --- a/net/ipv6/fib6_rules.c +++ b/net/ipv6/fib6_rules.c @@ -344,9 +344,9 @@ static int fib6_rule_configure(struct fib_rule *rule, struct sk_buff *skb, struct nlattr **tb, struct netlink_ext_ack *extack) { + struct fib6_rule *rule6 = (struct fib6_rule *)rule; + struct net *net = rule->fr_net; int err = -EINVAL; - struct net *net = sock_net(skb->sk); - struct fib6_rule *rule6 = (struct fib6_rule *) rule; if (rule->action == FR_ACT_TO_TBL && !rule->l3mdev) { if (rule->table == RT6_TABLE_UNSPEC) { -- 2.39.5