Re: [PATCH v12 2/3] rust: add parameter support to the `module!` macro

Andreas Hindborg
2025-06-11T13:29:02Z

"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:

> On Wed, Jun 11, 2025 at 2:24 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> So either we need to `#[allow(missing_docs)]` or just add the line back. What do you prefer?
>
> Do you mean if you remove the `concat!` too, right?

Yes, all of it.

>
> It would need to be `expect`, but I think even an
> `expect(missing_docs)` is not really useful vs. having some docs.
>
> But another question is: if the docs are not useful, should an item be
> hidden to begin with?

That is probably the best solution, yes.

> (By the way, that one is `rustc`, not Clippy)

Right.

Best regards,
Andreas Hindborg