* [PATCH v2] mfd: sm501: Remove unused sm501_find_clock
@ 2025-05-09 17:35 linux
2025-05-13 10:56 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2025-05-09 17:35 UTC (permalink / raw)
To: lee; +Cc: linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
sm501_find_clock() was added in 2007 as part of
commit b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
but hasn't been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
v2
Clean up the header (as per Lee's review)
drivers/mfd/sm501.c | 43 -------------------------------------------
include/linux/sm501.h | 3 ---
2 files changed, 46 deletions(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index 7ee293b09f62..bdeea0047e1b 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -631,49 +631,6 @@ unsigned long sm501_set_clock(struct device *dev,
EXPORT_SYMBOL_GPL(sm501_set_clock);
-/* sm501_find_clock
- *
- * finds the closest available frequency for a given clock
-*/
-
-unsigned long sm501_find_clock(struct device *dev,
- int clksrc,
- unsigned long req_freq)
-{
- struct sm501_devdata *sm = dev_get_drvdata(dev);
- unsigned long sm501_freq; /* the frequency achieveable by the 501 */
- struct sm501_clock to;
-
- switch (clksrc) {
- case SM501_CLOCK_P2XCLK:
- if (sm->rev >= 0xC0) {
- /* SM502 -> use the programmable PLL */
- sm501_freq = (sm501_calc_pll(2 * req_freq,
- &to, 5) / 2);
- } else {
- sm501_freq = (sm501_select_clock(2 * req_freq,
- &to, 5) / 2);
- }
- break;
-
- case SM501_CLOCK_V2XCLK:
- sm501_freq = (sm501_select_clock(2 * req_freq, &to, 3) / 2);
- break;
-
- case SM501_CLOCK_MCLK:
- case SM501_CLOCK_M1XCLK:
- sm501_freq = sm501_select_clock(req_freq, &to, 3);
- break;
-
- default:
- sm501_freq = 0; /* error */
- }
-
- return sm501_freq;
-}
-
-EXPORT_SYMBOL_GPL(sm501_find_clock);
-
static struct sm501_device *to_sm_device(struct platform_device *pdev)
{
return container_of(pdev, struct sm501_device, pdev);
diff --git a/include/linux/sm501.h b/include/linux/sm501.h
index 2f3488b2875d..bcda27a46e7a 100644
--- a/include/linux/sm501.h
+++ b/include/linux/sm501.h
@@ -12,9 +12,6 @@ extern int sm501_unit_power(struct device *dev,
extern unsigned long sm501_set_clock(struct device *dev,
int clksrc, unsigned long freq);
-extern unsigned long sm501_find_clock(struct device *dev,
- int clksrc, unsigned long req_freq);
-
/* sm501_misc_control
*
* Modify the SM501's MISC_CONTROL register
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH v2] mfd: sm501: Remove unused sm501_find_clock
2025-05-09 17:35 [PATCH v2] mfd: sm501: Remove unused sm501_find_clock linux
@ 2025-05-13 10:56 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2025-05-13 10:56 UTC (permalink / raw)
To: lee, linux; +Cc: linux-kernel
On Fri, 09 May 2025 18:35:20 +0100, linux@treblig.org wrote:
> sm501_find_clock() was added in 2007 as part of
> commit b6d6454fdb66 ("[PATCH] mfd: SM501 core driver")
> but hasn't been used.
>
> Remove it.
>
>
> [...]
Applied, thanks!
[1/1] mfd: sm501: Remove unused sm501_find_clock
commit: b6d21359b036bf48ef94757b45cf691b89ec139a
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-13 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-09 17:35 [PATCH v2] mfd: sm501: Remove unused sm501_find_clock linux
2025-05-13 10:56 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).