Re: [PATCH] ALSA: msnd: Remove midi code

Dr. David Alan Gilbert
2025-05-12T11:18:50Z

* Takashi Iwai (tiwai@suse.de) wrote:
> On Sun, 11 May 2025 19:29:57 +0200,
> linux@treblig.org wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Nothing calls snd_msndmidi_new()
> > thus nothing sets chip->msndmidi_mpu
> > The call to snd_msndmidi_input_read is gated on that being set,
> > so snd_msndmidi_input_read() won't be called either.
> >
> > This is probably a missing call to snd_msndmidi_new(), but since
> > this is ancient code, it's probably best to remove it (especially
> > since I don't have the hardware to test it).
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Applied now. Thanks.

Thanks!

Dave

>
> Takashi
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/