Re: [PATCH net-next 08/10] net: add skb_copy_and_crc32c_datagram_iter()

Eric Biggers
2025-05-15T18:09:04Z

On Tue, May 13, 2025 at 02:41:54PM -0700, Jakub Kicinski wrote:
> On Sat, 10 May 2025 17:41:08 -0700 Eric Biggers wrote:
> > +/**
> > + * skb_copy_and_crc32c_datagram_iter - Copy datagram to an iovec iterator
> > + * and update a CRC32C value.
> > + * @skb: buffer to copy
> > + * @offset: offset in the buffer to start copying from
> > + * @to: iovec iterator to copy to
> > + * @len: amount of data to copy from buffer to iovec
> > + * @crcp: pointer to CRC32C value to update
> > + */
>
> When you repost please toss a Return: statement here.
> kernel-doc -Wall is complaining

I'll plan to fold in the following:

diff --git a/net/core/datagram.c b/net/core/datagram.c
index 3599eda959917..fa87abb666324 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -538,10 +538,12 @@ static size_t crc32c_and_copy_to_iter(const void *addr, size_t bytes,
* @skb: buffer to copy
* @offset: offset in the buffer to start copying from
* @to: iovec iterator to copy to
* @len: amount of data to copy from buffer to iovec
* @crcp: pointer to CRC32C value to update
+ *
+ * Return: 0 on success, -EFAULT if there was a fault during copy.
*/
int skb_copy_and_crc32c_datagram_iter(const struct sk_buff *skb, int offset,
struct iov_iter *to, int len, u32 *crcp)
{
return __skb_datagram_iter(skb, offset, to, len, true,