linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chen Ridong <chenridong@huaweicloud.com>,
	paulmck@kernel.org, legion@kernel.org, roman.gushchin@linux.dev,
	brauner@kernel.org, tglx@linutronix.de, frederic@kernel.org,
	peterz@infradead.org, oleg@redhat.com, joel.granados@kernel.org,
	viro@zeniv.linux.org.uk, lorenzo.stoakes@oracle.com,
	avagin@google.com, mengensun@tencent.com, linux@weissschuh.net,
	jlayton@kernel.org, ruanjinjie@huawei.com, kees@kernel.org,
	linux-kernel@vger.kernel.org, lujialin4@huawei.com
Subject: Re: [RFC next v2 0/5] ucount: add rlimit cache for ucount
Date: Mon, 12 May 2025 12:48:28 +0200	[thread overview]
Message-ID: <20250512104828.hjVjvmT3@linutronix.de> (raw)
In-Reply-To: <20250509131849.112545d60dd7bb2d28c3b966@linux-foundation.org>

On 2025-05-09 13:18:49 [-0700], Andrew Morton wrote:
> On Fri,  9 May 2025 07:20:49 +0000 Chen Ridong <chenridong@huaweicloud.com> wrote:
> 
> > The will-it-scale test case signal1 [1] has been observed. and the test
> > results reveal that the signal sending system call lacks linearity.
> > To further investigate this issue, we initiated a series of tests by
> > launching varying numbers of dockers and closely monitored the throughput
> > of each individual docker. The detailed test outcomes are presented as
> > follows:
> > 
> > 	| Dockers     |1      |4      |8      |16     |32     |64     |
> > 	| Throughput  |380068 |353204 |308948 |306453 |180659 |129152 |
> > 
> > The data clearly demonstrates a discernible trend: as the quantity of
> > dockers increases, the throughput per container progressively declines.
> > In-depth analysis has identified the root cause of this performance
> > degradation. The ucouts module conducts statistics on rlimit, which
> > involves a significant number of atomic operations. These atomic
> > operations, when acting on the same variable, trigger a substantial number
> > of cache misses or remote accesses, ultimately resulting in a drop in
> > performance.
> 
> Did you consider simply turning that atomic_t counter into a
> percpu_counter?

That sounds like a smaller change. Also, do these 1…64 docker container
play signal ping-pong or is there a real workload behind it?

Sebastian

  reply	other threads:[~2025-05-12 10:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09  7:20 [RFC next v2 0/5] ucount: add rlimit cache for ucount Chen Ridong
2025-05-09  7:20 ` [RFC next v2 1/5] user_namespace: add children list node Chen Ridong
2025-05-09  7:20 ` [RFC next v2 2/5] usernamespace: make usernamespace rcu safe Chen Ridong
2025-05-09  7:20 ` [RFC next v2 3/5] user_namespace: add user_ns iteration helper Chen Ridong
2025-05-09  7:20 ` [RFC next v2 4/5] uounts: factor out __inc_rlimit_get_ucounts/__dec_rlimit_put_ucounts Chen Ridong
2025-05-09  7:20 ` [RFC next v2 5/5] ucount: add rlimit cache for ucount Chen Ridong
2025-05-09 20:18 ` [RFC next v2 0/5] " Andrew Morton
2025-05-12 10:48   ` Sebastian Andrzej Siewior [this message]
2025-05-13  1:48     ` Chen Ridong
2025-05-15 10:29 ` Christian Brauner
2025-05-15 12:04   ` Chen Ridong
2025-05-16 11:48 ` Alexey Gladkov
2025-05-19 13:39   ` Chen Ridong
2025-05-19 16:32     ` Alexey Gladkov
2025-05-21  1:32       ` Chen Ridong
2025-05-21  7:29         ` Alexey Gladkov
2025-05-22 22:48           ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512104828.hjVjvmT3@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@google.com \
    --cc=brauner@kernel.org \
    --cc=chenridong@huaweicloud.com \
    --cc=frederic@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=joel.granados@kernel.org \
    --cc=kees@kernel.org \
    --cc=legion@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=lujialin4@huawei.com \
    --cc=mengensun@tencent.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=roman.gushchin@linux.dev \
    --cc=ruanjinjie@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).