On Tue, May 13, 2025 at 11:19:05AM +0100, Jon Hunter wrote:

> > > +  - $ref: spi-controller.yaml#
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: nvidia,tegra234-qspi
> > 
> > > +    then:
> > > +      properties:
> > > +        iommus: true
> > 
> > This is a NOP, no?
> > Just invert the case above and drop a clause.
> 
> 
> Yes that's true. So just to confirm, your preference is this ...
> 
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 04d3b1a47392..c45511e9a9ed 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -74,11 +74,13 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: nvidia,tegra234-qspi
> +          contains:
> +            enum:
> +              - nvidia,tegra210-qspi
> +              - nvidia,tegra186-qspi
> +              - nvidia,tegra194-qspi
> +              - nvidia,tegra241-qspi
>      then:
> -      properties:
> -        iommus: true
> -    else:
>        properties:
>          iommus: false

You can just invert the condition directly with a not:,
so "if: properties: compatible: not: contains:" should do the trick.