From: Simon Horman <horms@kernel.org>
To: Zak Kemble <zakkemble@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: bcmgenet: tidy up stats, expose more stats in ethtool
Date: Tue, 13 May 2025 10:45:01 +0100 [thread overview]
Message-ID: <20250513094501.GX3339421@horms.kernel.org> (raw)
In-Reply-To: <20250512101521.1350-1-zakkemble@gmail.com>
On Mon, May 12, 2025 at 11:15:20AM +0100, Zak Kemble wrote:
> This patch exposes more statistics counters in ethtool and tidies up the
> counters so that they are all per-queue. The netdev counters are now only
> updated synchronously in bcmgenet_get_stats instead of a mix of sync/async
> throughout the driver. Hardware discarded packets are now counted in their
> own missed stat instead of being lumped in with general errors.
>
> Changes in v2:
> - Remove unused variable
> - Link to v1: https://lore.kernel.org/all/20250511214037.2805-1-zakkemble%40gmail.com
Hi Zak,
nit: These days it is preferred to put Changes information, such as the
above, below the scissors ("---"). That way it is available to
reviewers (thanks!) and will appear in mailing list archives and so
on. But is omitted in git history as the commit message is
truncated at the scissors.
>
> Signed-off-by: Zak Kemble <zakkemble@gmail.com>
This does not appear to address the review of Andrew and Florian of v1.
I think the way forwards is to engage with them on the preferred way
forwards. Or somehow note that you have done so.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-05-13 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 10:15 [PATCH v2] net: bcmgenet: tidy up stats, expose more stats in ethtool Zak Kemble
2025-05-13 9:45 ` Simon Horman [this message]
2025-05-13 19:26 ` Zak Kemble
2025-05-15 7:29 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513094501.GX3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=zakkemble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox