Re: [PATCH] apparmor: use SHA-256 library API instead of crypto_shash API

Eric Biggers
2025-06-12T19:11:32Z

On Sat, May 17, 2025 at 12:43:30AM -0700, John Johansen wrote:
> On 5/13/25 21:21, Eric Biggers wrote:
> > On Mon, Apr 28, 2025 at 12:04:30PM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > This user of SHA-256 does not support any other algorithm, so the
> > > crypto_shash abstraction provides no value. Just use the SHA-256
> > > library API instead, which is much simpler and easier to use.
> > >
> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > > ---
> > >
> > > This patch is targeting the apparmor tree for 6.16.
> > >
> > > security/apparmor/Kconfig | 3 +-
> > > security/apparmor/crypto.c | 85 ++++++--------------------------------
> > > 2 files changed, 13 insertions(+), 75 deletions(-)
> >
> > Any interest in taking this patch through the apparmor or security trees?
> >
> I can take it through my tree

Thanks! I notice this isn't in v6.16-rc1. Do you have a pull request planned?

- Eric