From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jiri@resnulli.us, andrew+netdev@lunn.ch,
sdf@fomichev.me, linux-kernel@vger.kernel.org,
syzbot+53485086a41dbb43270a@syzkaller.appspotmail.com
Subject: Re: [PATCH net] team: grab team lock during team_change_rx_flags
Date: Thu, 15 May 2025 07:56:26 -0700 [thread overview]
Message-ID: <20250515075626.43fbd0e0@kernel.org> (raw)
In-Reply-To: <20250514220319.3505158-1-stfomichev@gmail.com>
On Wed, 14 May 2025 15:03:19 -0700 Stanislav Fomichev wrote:
> --- a/drivers/net/team/team_core.c
> +++ b/drivers/net/team/team_core.c
> @@ -1778,8 +1778,8 @@ static void team_change_rx_flags(struct net_device *dev, int change)
> struct team_port *port;
> int inc;
>
> - rcu_read_lock();
> - list_for_each_entry_rcu(port, &team->port_list, list) {
> + mutex_lock(&team->lock);
> + list_for_each_entry(port, &team->port_list, list) {
I'm not sure if change_rx_flags is allowed to sleep.
Could you try to test it on a bond with a child without IFF_UNICAST_FLT,
add an extra unicast address to the bond and remove it?
That should flip promisc on and off IIUC.
next prev parent reply other threads:[~2025-05-15 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 22:03 [PATCH net] team: grab team lock during team_change_rx_flags Stanislav Fomichev
2025-05-15 14:56 ` Jakub Kicinski [this message]
2025-05-15 15:40 ` Stanislav Fomichev
2025-05-15 16:21 ` Stanislav Fomichev
2025-05-15 16:39 ` Jay Vosburgh
2025-05-15 18:26 ` Stanislav Fomichev
2025-05-16 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515075626.43fbd0e0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stfomichev@gmail.com \
--cc=syzbot+53485086a41dbb43270a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).