From: Alexandru Soponar <asoponar@taladin.ro>
To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org, linux-leds@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: jdelvare@suse.com, linux@roeck-us.net, jic23@kernel.org,
pavel@ucw.cz, lee@kernel.org, baocheng.su@siemens.com,
wim@linux-watchdog.org, tobias.schaffner@siemens.com,
angelogioacchino.delregno@collabora.com,
benedikt.niedermayr@siemens.com, matthias.bgg@gmail.com,
aardelean@baylibre.com, contact@sopy.one,
Alexandru Soponar <asoponar@taladin.ro>
Subject: [PATCH 03/16] hwmon: ina3221: Fix type incompatibility with non-macro find_closest
Date: Thu, 15 May 2025 11:13:19 +0300 [thread overview]
Message-ID: <20250515081332.151250-4-asoponar@taladin.ro> (raw)
In-Reply-To: <20250515081332.151250-1-asoponar@taladin.ro>
The ina3221_conv_time array was previously declared as u16 but used with
find_closest(). With find_closest() now implemented as a function taking
signed int parameters instead of a macro, passing unsigned arrays causes
type incompatibility errors. This patch changes the array type from
u16 to int to ensure compatibility with the function signature and
prevent compilation errors.
Signed-off-by: Alexandru Soponar <asoponar@taladin.ro>
---
drivers/hwmon/ina3221.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
index 1bf479a0f793..482ab8e53d5c 100644
--- a/drivers/hwmon/ina3221.c
+++ b/drivers/hwmon/ina3221.c
@@ -178,7 +178,7 @@ static inline int ina3221_summation_shunt_resistor(struct ina3221_data *ina)
}
/* Lookup table for Bus and Shunt conversion times in usec */
-static const u16 ina3221_conv_time[] = {
+static const int ina3221_conv_time[] = {
140, 204, 332, 588, 1100, 2116, 4156, 8244,
};
@@ -192,7 +192,7 @@ static inline u32 ina3221_interval_ms_to_conv_time(u16 config, int interval)
{
u32 channels = hweight16(config & INA3221_CONFIG_CHs_EN_MASK);
u32 samples_idx = INA3221_CONFIG_AVG(config);
- u32 samples = ina3221_avg_samples[samples_idx];
+ int samples = ina3221_avg_samples[samples_idx];
/* Bisect the result to Bus and Shunt conversion times */
return DIV_ROUND_CLOSEST(interval * 1000 / 2, channels * samples);
@@ -204,8 +204,8 @@ static inline u32 ina3221_reg_to_interval_us(u16 config)
u32 channels = hweight16(config & INA3221_CONFIG_CHs_EN_MASK);
u32 vbus_ct_idx = INA3221_CONFIG_VBUS_CT(config);
u32 vsh_ct_idx = INA3221_CONFIG_VSH_CT(config);
- u32 vbus_ct = ina3221_conv_time[vbus_ct_idx];
- u32 vsh_ct = ina3221_conv_time[vsh_ct_idx];
+ int vbus_ct = ina3221_conv_time[vbus_ct_idx];
+ int vsh_ct = ina3221_conv_time[vsh_ct_idx];
/* Calculate total conversion time */
return channels * (vbus_ct + vsh_ct);
--
2.49.0
next prev parent reply other threads:[~2025-05-15 8:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 8:13 [PATCH 0/16] lib: Refactor find_closest() and find_closest_descending() from macros to lib functions Alexandru Soponar
2025-05-15 8:13 ` [PATCH 01/16] hwmon: w83795: Fix type incompatibility with non-macro find_closest Alexandru Soponar
2025-05-15 8:13 ` [PATCH 02/16] hwmon: emc1403: " Alexandru Soponar
2025-05-15 8:13 ` Alexandru Soponar [this message]
2025-05-15 8:13 ` [PATCH 04/16] hwmon: lm95234: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 05/16] hwmon: max1619: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 06/16] hwmon: lm75: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 07/16] hwmon: ltc4282: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 08/16] hwmon: max6639: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 09/16] hwmon: max20740: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 10/16] iio: ad7606: " Alexandru Soponar
2025-05-15 17:13 ` Jonathan Cameron
2025-05-15 8:13 ` [PATCH 11/16] iio: mcp3564: " Alexandru Soponar
2025-05-15 17:14 ` Jonathan Cameron
2025-05-19 8:09 ` Marius.Cristea
2025-05-15 8:13 ` [PATCH 12/16] iio: max44009: " Alexandru Soponar
2025-05-15 17:14 ` Jonathan Cameron
2025-05-15 8:13 ` [PATCH 13/16] leds: eds-mt6370-rgb: Fix type incompatibility with find_closest() Alexandru Soponar
2025-05-22 14:33 ` Lee Jones
2025-05-15 8:13 ` [PATCH 14/16] regulator: max77857: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 15/16] watchdog: simatic-ipc-wdt: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 16/16] lib: move find_closest() and find_closest_descending() to lib functions Alexandru Soponar
2025-05-19 16:35 ` David Lechner
2025-05-19 15:44 ` [PATCH 0/16] lib: Refactor find_closest() and find_closest_descending() from macros " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515081332.151250-4-asoponar@taladin.ro \
--to=asoponar@taladin.ro \
--cc=aardelean@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baocheng.su@siemens.com \
--cc=benedikt.niedermayr@siemens.com \
--cc=contact@sopy.one \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=lee@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).