[PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[Tanav Chinthapatla]

[-- Attachment #1.1: Type: text/plain, Size: 182 bytes --]

Hi,

This patch fixes a checkpatch style issue in the rtl8723bs driver by
correcting spacing around a '+' operator.

The patch is attached to this email.

Thanks,
Tanav Chinthapatla

[-- Attachment #1.2: Type: text/html, Size: 282 bytes --]

[-- Attachment #2: 0001-staging-rtl8723bs-fix-spacing-around-in-rtw_cmd.c.patch --]
[-- Type: application/octet-stream, Size: 975 bytes --]

From 25aa24c7cde7df5901674ec08090992b17afd5b4 Mon Sep 17 00:00:00 2001
From: Tanav Chinthapatla <tanavc01@gmail.com>
Date: Tue, 13 May 2025 00:16:29 -0500
Subject: [PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

Signed-off-by: Tanav Chinthapatla <tanavc01@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 1c9e8b01d..98d89e836 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1619,7 +1619,7 @@ static void rtw_btinfo_hdl(struct adapter *adapter, u8 *buf, u16 buf_len)
 		buf[1] = 0;
 	else if (cmd_idx == BTINFO_BT_AUTO_RPT)
 		buf[1] = 2;
-	hal_btcoex_BtInfoNotify(adapter, len+1, &buf[1]);
+	hal_btcoex_BtInfoNotify(adapter, len + 1, &buf[1]);
 }
 
 u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[Greg KH]

On Tue, May 13, 2025 at 01:53:20AM -0400, Tanav Chinthapatla wrote:
> Hi,
> 
> This patch fixes a checkpatch style issue in the rtl8723bs driver by
> correcting spacing around a '+' operator.
> 
> The patch is attached to this email.


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- Your email was sent in HTML format, which is rejected by the mailing
  lists and does not work for kernel development.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[Tanav Chinthapatla]

Signed-off-by: Tanav Chinthapatla <tanavc01@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 1c9e8b01d..98d89e836 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1619,7 +1619,7 @@ static void rtw_btinfo_hdl(struct adapter *adapter, u8 *buf, u16 buf_len)
 		buf[1] = 0;
 	else if (cmd_idx == BTINFO_BT_AUTO_RPT)
 		buf[1] = 2;
-	hal_btcoex_BtInfoNotify(adapter, len+1, &buf[1]);
+	hal_btcoex_BtInfoNotify(adapter, len + 1, &buf[1]);
 }
 
 u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[Ozgur Kara]

Greg KH <gregkh@linuxfoundation.org>, 13 May 2025 Sal, 09:41 tarihinde
şunu yazdı:
>
> On Tue, May 13, 2025 at 01:53:20AM -0400, Tanav Chinthapatla wrote:
> > Hi,
> >
> > This patch fixes a checkpatch style issue in the rtl8723bs driver by
> > correcting spacing around a '+' operator.
> >
> > The patch is attached to this email.

Hello,

I dont think kernel developers will patch email additional files but
try this method.

Fix this file you are looking at with checkpatch.pl script,

then run add this file to your git repo command: git add file.c
and run a commit command: git commit -s -m "[PATCH] staging: x x"
finally, run patch command: git format-patch -1

in the end, it gives you a file called 0001-**.patch file and you can
literally email this file content here,
maybe if you look at the other patch emails sent they contain lines like

changed, insertions, deletions
foo
bar
end with diff version like for example 2.39.5.

Regards

Ozgur

>
>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - Your patch was attached, please place it inline so that it can be
>   applied directly from the email message itself.
>
> - Your email was sent in HTML format, which is rejected by the mailing
>   lists and does not work for kernel development.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot
>
>
>

Re: [PATCH] staging: rtl8723bs: fix spacing around '+' in rtw_cmd.c

[Dan Carpenter]

You'll need to resend.  Here is a guide.

https://nickdesaulniers.github.io/blog/2017/05/16/submitting-your-first-patch-to-the-linux-kernel-and-responding-to-feedback/

regards,
dan carpenter