From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Xu <peterx@redhat.com>, Yan Zhao <yan.y.zhao@intel.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
James Houghton <jthoughton@google.com>,
Sean Christopherson <seanjc@google.com>,
Pankaj Gupta <pankaj.gupta@amd.com>
Subject: [PATCH v3 2/6] KVM: Bail from the dirty ring reset flow if a signal is pending
Date: Fri, 16 May 2025 14:35:36 -0700 [thread overview]
Message-ID: <20250516213540.2546077-3-seanjc@google.com> (raw)
In-Reply-To: <20250516213540.2546077-1-seanjc@google.com>
Abort a dirty ring reset if the current task has a pending signal, as the
hard limit of INT_MAX entries doesn't ensure KVM will respond to a signal
in a timely fashion.
Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking")
Reviewed-by: James Houghton <jthoughton@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
virt/kvm/dirty_ring.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
index 77986f34eff8..e844e869e8c7 100644
--- a/virt/kvm/dirty_ring.c
+++ b/virt/kvm/dirty_ring.c
@@ -118,6 +118,9 @@ int kvm_dirty_ring_reset(struct kvm *kvm, struct kvm_dirty_ring *ring,
cur_slot = cur_offset = mask = 0;
while (likely((*nr_entries_reset) < INT_MAX)) {
+ if (signal_pending(current))
+ return -EINTR;
+
entry = &ring->dirty_gfns[ring->reset_index & (ring->size - 1)];
if (!kvm_dirty_gfn_harvested(entry))
--
2.49.0.1112.g889b7c5bd8-goog
next prev parent reply other threads:[~2025-05-16 21:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 21:35 [PATCH v3 0/6] KVM: Dirty ring fixes and cleanups Sean Christopherson
2025-05-16 21:35 ` [PATCH v3 1/6] KVM: Bound the number of dirty ring entries in a single reset at INT_MAX Sean Christopherson
2025-05-20 6:51 ` Binbin Wu
2025-05-16 21:35 ` Sean Christopherson [this message]
2025-05-20 6:53 ` [PATCH v3 2/6] KVM: Bail from the dirty ring reset flow if a signal is pending Binbin Wu
2025-05-16 21:35 ` [PATCH v3 3/6] KVM: Conditionally reschedule when resetting the dirty ring Sean Christopherson
2025-05-16 21:35 ` [PATCH v3 4/6] KVM: Check for empty mask of harvested dirty ring entries in caller Sean Christopherson
2025-05-20 6:56 ` Binbin Wu
2025-05-21 9:16 ` Yan Zhao
2025-05-21 14:55 ` Sean Christopherson
2025-05-16 21:35 ` [PATCH v3 5/6] KVM: Use mask of harvested dirty ring entries to coalesce dirty ring resets Sean Christopherson
2025-05-20 6:58 ` Binbin Wu
2025-05-21 9:16 ` Yan Zhao
2025-05-21 14:54 ` Sean Christopherson
2025-05-21 19:45 ` Sean Christopherson
2025-05-22 1:04 ` Yan Zhao
2025-05-16 21:35 ` [PATCH v3 6/6] KVM: Assert that slots_lock is held when resetting per-vCPU dirty rings Sean Christopherson
2025-05-20 7:04 ` Binbin Wu
2025-05-20 19:12 ` [PATCH v3 0/6] KVM: Dirty ring fixes and cleanups Peter Xu
2025-05-20 23:16 ` Sean Christopherson
2025-05-20 23:51 ` Peter Xu
2025-05-21 14:50 ` Sean Christopherson
2025-05-21 15:24 ` Peter Xu
2025-05-21 9:21 ` Yan Zhao
2025-06-24 19:36 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516213540.2546077-3-seanjc@google.com \
--to=seanjc@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pankaj.gupta@amd.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox