From: Al Viro <viro@zeniv.linux.org.uk>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
willemb@google.com, sagi@grimberg.me, asml.silence@gmail.com,
almasrymina@google.com, kaiyuanz@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: devmem: remove min_t(iter_iov_len) in sendmsg
Date: Sat, 17 May 2025 01:09:07 +0100 [thread overview]
Message-ID: <20250517000907.GW2023217@ZenIV> (raw)
In-Reply-To: <20250517000431.558180-1-stfomichev@gmail.com>
On Fri, May 16, 2025 at 05:04:31PM -0700, Stanislav Fomichev wrote:
> iter_iov_len looks broken for UBUF. When iov_iter_advance is called
> for UBUF, it increments iov_offset and also decrements the count.
> This makes the iterator only go over half of the range (unless I'm
> missing something).
What do you mean by "broken"? iov_iter_len(from) == "how much data is
left in that iterator". That goes for all flavours, UBUF included...
Confused...
next prev parent reply other threads:[~2025-05-17 0:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 0:04 [PATCH net-next] net: devmem: remove min_t(iter_iov_len) in sendmsg Stanislav Fomichev
2025-05-17 0:09 ` Al Viro [this message]
2025-05-17 1:24 ` Stanislav Fomichev
2025-05-17 2:06 ` Al Viro
2025-05-17 2:17 ` Stanislav Fomichev
2025-05-17 3:39 ` Al Viro
2025-05-17 3:53 ` Stanislav Fomichev
2025-05-17 4:05 ` Al Viro
2025-05-17 4:29 ` Stanislav Fomichev
2025-05-17 4:53 ` Mina Almasry
2025-05-20 15:10 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250517000907.GW2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=stfomichev@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox