From: Simon Horman <horms@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info
Date: Mon, 19 May 2025 17:02:37 +0100 [thread overview]
Message-ID: <20250519160237.GJ365796@horms.kernel.org> (raw)
In-Reply-To: <20250516122655.442808-1-nm@ti.com>
On Fri, May 16, 2025 at 07:26:55AM -0500, Nishanth Menon wrote:
> Using random mac address is not an error since the driver continues to
> function, it should be informative that the system has not assigned
> a MAC address. This is inline with other drivers such as ax88796c,
> dm9051 etc. Drop the error level to info level.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> This is esp irritating on platforms such as J721E-IDK-GW which has a
> bunch of ethernet interfaces, and not all of them have MAC address
> assigned from Efuse.
> Example log (next-20250515):
> https://gist.github.com/nmenon/8edbc1773c150a5be69f5b700d907ceb#file-j721e-idk-gw-L1588
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-19 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 12:26 [PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info Nishanth Menon
2025-05-19 16:02 ` Simon Horman [this message]
2025-05-20 12:14 ` Roger Quadros
2025-05-21 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519160237.GJ365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox