From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Akira Yokosawa <akiyks@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Nicolas Schier <nicolas.schier@linux.dev>,
linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] docs: kerneldoc.py: don't use Sphinx logger
Date: Tue, 20 May 2025 21:39:06 +1000 [thread overview]
Message-ID: <20250520213906.6ec263d8@canb.auug.org.au> (raw)
In-Reply-To: <20250520111956.1db9db88@sal.lan>
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Hi Mauro,
I do appreciate your work on the document system. Particularly you
have made the process much faster. However, see below.
On Tue, 20 May 2025 11:19:56 +0200 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
>
> If by "innocent typo" you mean removing/renaming/moving a file from
> the Kernel tree without updating Makefiles, or adding them with wrong
> names, then yes: I do think this should be fatal for the affected "make"
> targets. The quickest such build issues are caught, the best for everyone.
They are found if you leave them as warnings and just continue on. I
have been finding them by when the current python version just crashes
(without any useful message before your current change) I rerun the
htmldocs using the perl version to get the name of the missing file and
then report it so it can be fixed. But the perl version continues on
and produces all the other warnings so I can compare with the previous
and only report new errors/warnigs. Sometime these reports are not
foxed for days or weeks (or months).
So, please, now that you are producing more warnings, make a missing
file just a warning (or at least continue on). I have enough to do
every day without having to run "make htmldocs" more than once.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-05-20 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 5:47 [PATCH 0/1] docs: kernel-doc: doesn't suppress error/warnings Mauro Carvalho Chehab
2025-05-20 5:47 ` [PATCH 1/1] docs: kerneldoc.py: don't use Sphinx logger Mauro Carvalho Chehab
2025-05-20 5:55 ` Randy Dunlap
2025-05-20 7:50 ` Mauro Carvalho Chehab
2025-05-20 8:23 ` Akira Yokosawa
2025-05-20 9:19 ` Mauro Carvalho Chehab
2025-05-20 11:39 ` Stephen Rothwell [this message]
2025-05-20 13:09 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520213906.6ec263d8@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akiyks@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox