linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND 0/2] media: nxp,imx8-jpeg: Add imx95 support
@ 2025-05-21 17:34 Frank Li
  2025-05-21 17:34 ` [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG Frank Li
  2025-05-21 17:34 ` [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes Frank Li
  0 siblings, 2 replies; 13+ messages in thread
From: Frank Li @ 2025-05-21 17:34 UTC (permalink / raw)
  To: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

Update binding doc for imx95 support.
Update dts to support imx95

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (2):
      media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
      arm64: dts: imx95: add jpeg encode and decode nodes

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml   | 28 ++++++++++++--
 arch/arm64/boot/dts/freescale/imx95.dtsi           | 44 ++++++++++++++++++++++
 2 files changed, 69 insertions(+), 3 deletions(-)
---
base-commit: f3df6ce76ecb8eb47f0d3198ab4b81df31217fa7
change-id: 20250221-95_jpeg-a4924523fff2

Best regards,
---
Frank Li <Frank.Li@nxp.com>
-- 
Frank Li <Frank.Li@nxp.com>


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-05-21 17:34 [PATCH RESEND 0/2] media: nxp,imx8-jpeg: Add imx95 support Frank Li
@ 2025-05-21 17:34 ` Frank Li
  2025-05-23 23:22   ` Nicolas Dufresne
  2025-05-21 17:34 ` [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes Frank Li
  1 sibling, 1 reply; 13+ messages in thread
From: Frank Li @ 2025-05-21 17:34 UTC (permalink / raw)
  To: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
are backward compatible with "nxp,imx8qxp-jpgdec" and
"nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
wrap and all slots together. Reduce minItems of power-domains to 1 for
i.MX95 and keep the same restriction for others.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/media/nxp,imx8-jpeg.yaml         | 28 +++++++++++++++++--
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 2be30c5fdc839..4cba42ba7cf72 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -22,10 +22,14 @@ properties:
             - nxp,imx8qxp-jpgdec
             - nxp,imx8qxp-jpgenc
       - items:
-          - const: nxp,imx8qm-jpgdec
+          - enum:
+              - nxp,imx8qm-jpgdec
+              - nxp,imx95-jpgdec
           - const: nxp,imx8qxp-jpgdec
       - items:
-          - const: nxp,imx8qm-jpgenc
+          - enum:
+              - nxp,imx8qm-jpgenc
+              - nxp,imx95-jpgenc
           - const: nxp,imx8qxp-jpgenc
 
   reg:
@@ -48,7 +52,7 @@ properties:
     description:
       List of phandle and PM domain specifier as documented in
       Documentation/devicetree/bindings/power/power_domain.txt
-    minItems: 2               # Wrapper and 1 slot
+    minItems: 1               # Wrapper and all slots
     maxItems: 5               # Wrapper and 4 slots
 
 required:
@@ -58,6 +62,24 @@ required:
   - interrupts
   - power-domains
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - nxp,imx95-jpgenc
+              - nxp,imx95-jpgdec
+    then:
+      properties:
+        power-domains:
+          maxItems: 1
+    else:
+      properties:
+        power-domains:
+          minItems: 2        # Wrapper and 1 slot
+
+
 additionalProperties: false
 
 examples:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes
  2025-05-21 17:34 [PATCH RESEND 0/2] media: nxp,imx8-jpeg: Add imx95 support Frank Li
  2025-05-21 17:34 ` [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG Frank Li
@ 2025-05-21 17:34 ` Frank Li
  2025-07-10  2:48   ` Frank Li
  1 sibling, 1 reply; 13+ messages in thread
From: Frank Li @ 2025-05-21 17:34 UTC (permalink / raw)
  To: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

Add jpeg encode\decode and related nodes for i.MX95.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95.dtsi | 44 ++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
index 632631a291122..d38bbe8b16d7e 100644
--- a/arch/arm64/boot/dts/freescale/imx95.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
@@ -3,6 +3,7 @@
  * Copyright 2024 NXP
  */
 
+#include <dt-bindings/clock/nxp,imx95-clock.h>
 #include <dt-bindings/dma/fsl-edma.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
@@ -1801,6 +1802,49 @@ pcie1_ep: pcie-ep@4c380000 {
 			status = "disabled";
 		};
 
+		vpu_blk_ctrl: clock-controller@4c410000 {
+			compatible = "nxp,imx95-vpu-csr", "syscon";
+			reg = <0x0 0x4c410000 0x0 0x10000>;
+			#clock-cells = <1>;
+			clocks = <&scmi_clk IMX95_CLK_VPUAPB>;
+			power-domains = <&scmi_devpd IMX95_PD_VPU>;
+			assigned-clocks = <&scmi_clk IMX95_CLK_VPUAPB>,
+					  <&scmi_clk IMX95_CLK_VPU>,
+					  <&scmi_clk IMX95_CLK_VPUJPEG>;
+			assigned-clock-parents = <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>,
+						 <&scmi_clk IMX95_CLK_SYSPLL1_PFD2>,
+						 <&scmi_clk IMX95_CLK_SYSPLL1_PFD0>;
+			assigned-clock-rates = <133333333>, <667000000>, <500000000>;
+		};
+
+		jpegdec: jpegdec@4c500000 {
+			compatible = "nxp,imx95-jpgdec", "nxp,imx8qxp-jpgdec";
+			reg = <0x0 0x4C500000 0x0 0x00050000>;
+			interrupts = <GIC_SPI 295 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&scmi_clk IMX95_CLK_VPU>,
+				 <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
+			assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
+			assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
+			power-domains = <&scmi_devpd IMX95_PD_VPU>;
+		};
+
+		jpegenc: jpegenc@4c550000 {
+			compatible = "nxp,imx95-jpgenc", "nxp,imx8qxp-jpgenc";
+			reg = <0x0 0x4C550000 0x0 0x00050000>;
+			interrupts = <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&scmi_clk IMX95_CLK_VPU>,
+				 <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
+			assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
+			assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
+			power-domains = <&scmi_devpd IMX95_PD_VPU>;
+		};
+
 		netcmix_blk_ctrl: syscon@4c810000 {
 			compatible = "nxp,imx95-netcmix-blk-ctrl", "syscon";
 			reg = <0x0 0x4c810000 0x0 0x8>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-05-21 17:34 ` [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG Frank Li
@ 2025-05-23 23:22   ` Nicolas Dufresne
  2025-05-24  6:27     ` Krzysztof Kozlowski
  2025-06-19  4:27     ` Shawn Guo
  0 siblings, 2 replies; 13+ messages in thread
From: Nicolas Dufresne @ 2025-05-23 23:22 UTC (permalink / raw)
  To: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, krzysztof.kozlowski
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

Hi,

Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
> are backward compatible with "nxp,imx8qxp-jpgdec" and
> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
> wrap and all slots together. Reduce minItems of power-domains to 1 for
> i.MX95 and keep the same restriction for others.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Krzysztof, will you take this one once the DTS part is ready ?

regards,
Nicolas

> ---
>  .../bindings/media/nxp,imx8-jpeg.yaml         | 28 +++++++++++++++++--
>  1 file changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> index 2be30c5fdc839..4cba42ba7cf72 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
> @@ -22,10 +22,14 @@ properties:
>              - nxp,imx8qxp-jpgdec
>              - nxp,imx8qxp-jpgenc
>        - items:
> -          - const: nxp,imx8qm-jpgdec
> +          - enum:
> +              - nxp,imx8qm-jpgdec
> +              - nxp,imx95-jpgdec
>            - const: nxp,imx8qxp-jpgdec
>        - items:
> -          - const: nxp,imx8qm-jpgenc
> +          - enum:
> +              - nxp,imx8qm-jpgenc
> +              - nxp,imx95-jpgenc
>            - const: nxp,imx8qxp-jpgenc
>  
>    reg:
> @@ -48,7 +52,7 @@ properties:
>      description:
>        List of phandle and PM domain specifier as documented in
>        Documentation/devicetree/bindings/power/power_domain.txt
> -    minItems: 2               # Wrapper and 1 slot
> +    minItems: 1               # Wrapper and all slots
>      maxItems: 5               # Wrapper and 4 slots
>  
>  required:
> @@ -58,6 +62,24 @@ required:
>    - interrupts
>    - power-domains
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nxp,imx95-jpgenc
> +              - nxp,imx95-jpgdec
> +    then:
> +      properties:
> +        power-domains:
> +          maxItems: 1
> +    else:
> +      properties:
> +        power-domains:
> +          minItems: 2        # Wrapper and 1 slot
> +
> +
>  additionalProperties: false
>  
>  examples:

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-05-23 23:22   ` Nicolas Dufresne
@ 2025-05-24  6:27     ` Krzysztof Kozlowski
  2025-06-19  4:27     ` Shawn Guo
  1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-24  6:27 UTC (permalink / raw)
  To: Nicolas Dufresne, Frank Li, mirela.rabulea, mchehab, robh,
	krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

On 24/05/2025 01:22, Nicolas Dufresne wrote:
> Hi,
> 
> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
>> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
>> are backward compatible with "nxp,imx8qxp-jpgdec" and
>> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
>> wrap and all slots together. Reduce minItems of power-domains to 1 for
>> i.MX95 and keep the same restriction for others.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> Krzysztof, will you take this one once the DTS part is ready ?
> 
No, that's a media patch, not a Samsung or any other subsystem I
maintain. I do not have write access to media tree.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-05-23 23:22   ` Nicolas Dufresne
  2025-05-24  6:27     ` Krzysztof Kozlowski
@ 2025-06-19  4:27     ` Shawn Guo
  2025-06-19 17:16       ` Nicolas Dufresne
  1 sibling, 1 reply; 13+ messages in thread
From: Shawn Guo @ 2025-06-19  4:27 UTC (permalink / raw)
  To: Nicolas Dufresne
  Cc: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, krzysztof.kozlowski, imx,
	linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote:
> Hi,
> 
> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
> > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
> > are backward compatible with "nxp,imx8qxp-jpgdec" and
> > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
> > wrap and all slots together. Reduce minItems of power-domains to 1 for
> > i.MX95 and keep the same restriction for others.
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> Krzysztof, will you take this one once the DTS part is ready ?

dt-bindings is the prerequisite of DTS.  DTS patch looks good to me
and I'm waiting for dt-bindings part to be applied first.

Shawn


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-06-19  4:27     ` Shawn Guo
@ 2025-06-19 17:16       ` Nicolas Dufresne
  2025-06-20  5:54         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Nicolas Dufresne @ 2025-06-19 17:16 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, krzysztof.kozlowski, imx,
	linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit :
> On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote:
> > Hi,
> > 
> > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
> > > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
> > > are backward compatible with "nxp,imx8qxp-jpgdec" and
> > > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
> > > wrap and all slots together. Reduce minItems of power-domains to 1 for
> > > i.MX95 and keep the same restriction for others.
> > > 
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > 
> > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> > 
> > Krzysztof, will you take this one once the DTS part is ready ?
> 
> dt-bindings is the prerequisite of DTS.  DTS patch looks good to me
> and I'm waiting for dt-bindings part to be applied first.

I was waiting for sign of life on the DTS part, we usually get some ack,
which is good sign we can take the bindings.

Nicolas

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-06-19 17:16       ` Nicolas Dufresne
@ 2025-06-20  5:54         ` Krzysztof Kozlowski
  2025-06-20 15:06           ` Nicolas Dufresne
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-20  5:54 UTC (permalink / raw)
  To: Nicolas Dufresne, Shawn Guo
  Cc: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, imx, linux-media, devicetree,
	linux-arm-kernel, linux-kernel, ming.qian

On 19/06/2025 19:16, Nicolas Dufresne wrote:
> Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit :
>> On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote:
>>> Hi,
>>>
>>> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
>>>> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
>>>> are backward compatible with "nxp,imx8qxp-jpgdec" and
>>>> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
>>>> wrap and all slots together. Reduce minItems of power-domains to 1 for
>>>> i.MX95 and keep the same restriction for others.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>
>>> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>>>
>>> Krzysztof, will you take this one once the DTS part is ready ?
>>
>> dt-bindings is the prerequisite of DTS.  DTS patch looks good to me
>> and I'm waiting for dt-bindings part to be applied first.
> 
> I was waiting for sign of life on the DTS part, we usually get some ack,
> which is good sign we can take the bindings.

Such process never happens. DT bindings are the prerequisite here and
platform maintainers wait for bindings to be accepted before taking DTS
or even sometimes reviewing DTS. Why even bother to review DTS if it
follows entirely incorrect binding?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-06-20  5:54         ` Krzysztof Kozlowski
@ 2025-06-20 15:06           ` Nicolas Dufresne
  2025-06-22 10:28             ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Nicolas Dufresne @ 2025-06-20 15:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Shawn Guo
  Cc: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, imx, linux-media, devicetree,
	linux-arm-kernel, linux-kernel, ming.qian

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

Le vendredi 20 juin 2025 à 07:54 +0200, Krzysztof Kozlowski a écrit :
> On 19/06/2025 19:16, Nicolas Dufresne wrote:
> > Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit :
> > > On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote:
> > > > Hi,
> > > > 
> > > > Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
> > > > > Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
> > > > > are backward compatible with "nxp,imx8qxp-jpgdec" and
> > > > > "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
> > > > > wrap and all slots together. Reduce minItems of power-domains to 1 for
> > > > > i.MX95 and keep the same restriction for others.
> > > > > 
> > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > 
> > > > Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> > > > 
> > > > Krzysztof, will you take this one once the DTS part is ready ?
> > > 
> > > dt-bindings is the prerequisite of DTS.  DTS patch looks good to me
> > > and I'm waiting for dt-bindings part to be applied first.
> > 
> > I was waiting for sign of life on the DTS part, we usually get some ack,
> > which is good sign we can take the bindings.
> 
> Such process never happens. DT bindings are the prerequisite here and
> platform maintainers wait for bindings to be accepted before taking DTS
> or even sometimes reviewing DTS. Why even bother to review DTS if it
> follows entirely incorrect binding?

You are the one requesting DTS with DT bindings for review purpose. You've
done so regularly this year.

As for review process, Ack are a workaround to a black whole in our review
process. Patches without any reply can either be un-reviewed due to lack
of time, or accepted. You do whatever you like, I'm just saying that clarity
can help to coordinate.

regards,
Nicolas

> 
> Best regards,
> Krzysztof

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG
  2025-06-20 15:06           ` Nicolas Dufresne
@ 2025-06-22 10:28             ` Krzysztof Kozlowski
  0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-22 10:28 UTC (permalink / raw)
  To: Nicolas Dufresne, Shawn Guo
  Cc: Frank Li, mirela.rabulea, mchehab, robh, krzk+dt, conor+dt,
	shawnguo, s.hauer, kernel, festevam, imx, linux-media, devicetree,
	linux-arm-kernel, linux-kernel, ming.qian

On 20/06/2025 17:06, Nicolas Dufresne wrote:
> Le vendredi 20 juin 2025 à 07:54 +0200, Krzysztof Kozlowski a écrit :
>> On 19/06/2025 19:16, Nicolas Dufresne wrote:
>>> Le jeudi 19 juin 2025 à 12:27 +0800, Shawn Guo a écrit :
>>>> On Fri, May 23, 2025 at 07:22:04PM -0400, Nicolas Dufresne wrote:
>>>>> Hi,
>>>>>
>>>>> Le mercredi 21 mai 2025 à 13:34 -0400, Frank Li a écrit :
>>>>>> Add compatible strings "nxp,imx95-jpgdec" and "nxp,imx95-jpgenc", which
>>>>>> are backward compatible with "nxp,imx8qxp-jpgdec" and
>>>>>> "nxp,imx8qxp-jpegenc". i.MX95 just need one power domain which combine
>>>>>> wrap and all slots together. Reduce minItems of power-domains to 1 for
>>>>>> i.MX95 and keep the same restriction for others.
>>>>>>
>>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>>>
>>>>> Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>>>>>
>>>>> Krzysztof, will you take this one once the DTS part is ready ?
>>>>
>>>> dt-bindings is the prerequisite of DTS.  DTS patch looks good to me
>>>> and I'm waiting for dt-bindings part to be applied first.
>>>
>>> I was waiting for sign of life on the DTS part, we usually get some ack,
>>> which is good sign we can take the bindings.
>>
>> Such process never happens. DT bindings are the prerequisite here and
>> platform maintainers wait for bindings to be accepted before taking DTS
>> or even sometimes reviewing DTS. Why even bother to review DTS if it
>> follows entirely incorrect binding?
> 
> You are the one requesting DTS with DT bindings for review purpose. You've
> done so regularly this year.

Yes, I asked for DTS for before/while reviewing very questionable
bindings and drivers. Was this reviewed already? Yes, it was. Therefore
after my review, how is this relevant?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes
  2025-05-21 17:34 ` [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes Frank Li
@ 2025-07-10  2:48   ` Frank Li
  2025-07-11  5:37     ` Shawn Guo
  0 siblings, 1 reply; 13+ messages in thread
From: Frank Li @ 2025-07-10  2:48 UTC (permalink / raw)
  To: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam
  Cc: imx, linux-media, devicetree, linux-arm-kernel, linux-kernel,
	ming.qian

On Wed, May 21, 2025 at 01:34:04PM -0400, Frank Li wrote:
> Add jpeg encode\decode and related nodes for i.MX95.

shawn:
	can you help check this?

Frank

>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx95.dtsi | 44 ++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
> index 632631a291122..d38bbe8b16d7e 100644
> --- a/arch/arm64/boot/dts/freescale/imx95.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
> @@ -3,6 +3,7 @@
>   * Copyright 2024 NXP
>   */
>
> +#include <dt-bindings/clock/nxp,imx95-clock.h>
>  #include <dt-bindings/dma/fsl-edma.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
> @@ -1801,6 +1802,49 @@ pcie1_ep: pcie-ep@4c380000 {
>  			status = "disabled";
>  		};
>
> +		vpu_blk_ctrl: clock-controller@4c410000 {
> +			compatible = "nxp,imx95-vpu-csr", "syscon";
> +			reg = <0x0 0x4c410000 0x0 0x10000>;
> +			#clock-cells = <1>;
> +			clocks = <&scmi_clk IMX95_CLK_VPUAPB>;
> +			power-domains = <&scmi_devpd IMX95_PD_VPU>;
> +			assigned-clocks = <&scmi_clk IMX95_CLK_VPUAPB>,
> +					  <&scmi_clk IMX95_CLK_VPU>,
> +					  <&scmi_clk IMX95_CLK_VPUJPEG>;
> +			assigned-clock-parents = <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>,
> +						 <&scmi_clk IMX95_CLK_SYSPLL1_PFD2>,
> +						 <&scmi_clk IMX95_CLK_SYSPLL1_PFD0>;
> +			assigned-clock-rates = <133333333>, <667000000>, <500000000>;
> +		};
> +
> +		jpegdec: jpegdec@4c500000 {
> +			compatible = "nxp,imx95-jpgdec", "nxp,imx8qxp-jpgdec";
> +			reg = <0x0 0x4C500000 0x0 0x00050000>;
> +			interrupts = <GIC_SPI 295 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&scmi_clk IMX95_CLK_VPU>,
> +				 <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
> +			assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
> +			assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
> +			power-domains = <&scmi_devpd IMX95_PD_VPU>;
> +		};
> +
> +		jpegenc: jpegenc@4c550000 {
> +			compatible = "nxp,imx95-jpgenc", "nxp,imx8qxp-jpgenc";
> +			reg = <0x0 0x4C550000 0x0 0x00050000>;
> +			interrupts = <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&scmi_clk IMX95_CLK_VPU>,
> +				 <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_ENC>;
> +			assigned-clocks = <&vpu_blk_ctrl IMX95_CLK_VPUBLK_JPEG_DEC>;
> +			assigned-clock-parents = <&scmi_clk IMX95_CLK_VPUJPEG>;
> +			power-domains = <&scmi_devpd IMX95_PD_VPU>;
> +		};
> +
>  		netcmix_blk_ctrl: syscon@4c810000 {
>  			compatible = "nxp,imx95-netcmix-blk-ctrl", "syscon";
>  			reg = <0x0 0x4c810000 0x0 0x8>;
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes
  2025-07-10  2:48   ` Frank Li
@ 2025-07-11  5:37     ` Shawn Guo
  2025-07-11  5:41       ` Shawn Guo
  0 siblings, 1 reply; 13+ messages in thread
From: Shawn Guo @ 2025-07-11  5:37 UTC (permalink / raw)
  To: Frank Li
  Cc: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam, imx, linux-media, devicetree,
	linux-arm-kernel, linux-kernel, ming.qian

On Wed, Jul 09, 2025 at 10:48:15PM -0400, Frank Li wrote:
> On Wed, May 21, 2025 at 01:34:04PM -0400, Frank Li wrote:
> > Add jpeg encode\decode and related nodes for i.MX95.
> 
> shawn:
> 	can you help check this?

It looks good to me.  But has the binding change been applied already?

Shawn


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes
  2025-07-11  5:37     ` Shawn Guo
@ 2025-07-11  5:41       ` Shawn Guo
  0 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2025-07-11  5:41 UTC (permalink / raw)
  To: Frank Li
  Cc: mirela.rabulea, mchehab, robh, krzk+dt, conor+dt, shawnguo,
	s.hauer, kernel, festevam, imx, linux-media, devicetree,
	linux-arm-kernel, linux-kernel, ming.qian

On Fri, Jul 11, 2025 at 01:37:58PM +0800, Shawn Guo wrote:
> On Wed, Jul 09, 2025 at 10:48:15PM -0400, Frank Li wrote:
> > On Wed, May 21, 2025 at 01:34:04PM -0400, Frank Li wrote:
> > > Add jpeg encode\decode and related nodes for i.MX95.
> > 
> > shawn:
> > 	can you help check this?
> 
> It looks good to me.  But has the binding change been applied already?

Ok, found the binding change on linux-next.  Applied 2/2, thanks!


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2025-07-11  5:42 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 17:34 [PATCH RESEND 0/2] media: nxp,imx8-jpeg: Add imx95 support Frank Li
2025-05-21 17:34 ` [PATCH RESEND 1/2] media: dt-bindings: nxp,imx8-jpeg: Add compatible strings for IMX95 JPEG Frank Li
2025-05-23 23:22   ` Nicolas Dufresne
2025-05-24  6:27     ` Krzysztof Kozlowski
2025-06-19  4:27     ` Shawn Guo
2025-06-19 17:16       ` Nicolas Dufresne
2025-06-20  5:54         ` Krzysztof Kozlowski
2025-06-20 15:06           ` Nicolas Dufresne
2025-06-22 10:28             ` Krzysztof Kozlowski
2025-05-21 17:34 ` [PATCH RESEND 2/2] arm64: dts: imx95: add jpeg encode and decode nodes Frank Li
2025-07-10  2:48   ` Frank Li
2025-07-11  5:37     ` Shawn Guo
2025-07-11  5:41       ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).