From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D7212E5B for ; Wed, 21 May 2025 06:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747807984; cv=none; b=ALdslCnBs5s46jFKJ2djwGMhkZMsqTM/2iHHxj+cn2s/bTxILeOwd5sPwK67gsMSB2rbZNLFY+cxKtrmXHXoH7Ohb9LS/0FRcfz2IACn8sGvDfExDlPlZv4Wa5R5bdwJjcr/l3LchpNcq9C3VGG753WWjNJDCMmMKgrDlJGGdJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747807984; c=relaxed/simple; bh=W2pNq8bQVNv22mm8YwKbTNI9n8GEVp4YjBe5OD3yI8c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W3in9vWkFZmKBv25SSoP+vWYv5ASO/WOw/ofg2dwWXRclyGuqNYbjpQnv16+A8YwelF9D16PN9qiex0k1ilmIXxVGl8bU85KYX8NwEr0f7FyzGqiLknsv3/ODk/moAm5NDos+mutqBxi2pVNV2Sz46N4yzqESExpD0+Dhc5Rn3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=CA0fBv+R; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="CA0fBv+R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1747807981; bh=W2pNq8bQVNv22mm8YwKbTNI9n8GEVp4YjBe5OD3yI8c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CA0fBv+RiJjadc+F8vayIVJvOLGqbeZVy7dkM0bCI2ZgT77GMksH5cCWB1Felt9jO L/p1723SxM501IkIuPjK3EUnRwHXq1C9rfVUq7hZeV5LrYi3NtJDETrc8bl200UiSO wXb9hJZHRL7QFqHHsWAUFb4nJli8cAd0uaZM76U983u0QAdQ00GAI/8bKaux2H16yU U91vjsooolZQLkIpX03VX8+btLOGq6OsUGqfcEJcCHAW1taapTGVc7k/AXgJu1WzdN vpHCV5AcCy4P519k0pahx4TVLbUTqzRaGEA/YDeaXcGknoBIuvJCirrxrtBXdkkS11 +8YPPy6oUb4Wg== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9B8F017E0FBA; Wed, 21 May 2025 08:13:00 +0200 (CEST) Date: Wed, 21 May 2025 08:12:54 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com, Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 5/5] drm/panfrost: Fix panfrost device variable name in devfreq Message-ID: <20250521081254.05fead9e@collabora.com> In-Reply-To: <20250520174634.353267-6-adrian.larumbe@collabora.com> References: <20250520174634.353267-1-adrian.larumbe@collabora.com> <20250520174634.353267-6-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 20 May 2025 18:44:02 +0100 Adri=C3=A1n Larumbe wrote: > Commit 64111a0e22a9 ("drm/panfrost: Fix incorrect updating of current > device frequency") was a Panfrost port of a similar fix in Panthor. >=20 > Fix the Panfrost device pointer variable name so that it follows > Panfrost naming conventions. >=20 > Signed-off-by: Adri=C3=A1n Larumbe > Fixes: 64111a0e22a9 ("drm/panfrost: Fix incorrect updating of current dev= ice frequency") I don't we want to backport this patch, so would drop the Fixes tag. Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/dr= m/panfrost/panfrost_devfreq.c > index 3385fd3ef41a..5d0dce10336b 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c > @@ -29,7 +29,7 @@ static void panfrost_devfreq_update_utilization(struct = panfrost_devfreq *pfdevfr > static int panfrost_devfreq_target(struct device *dev, unsigned long *fr= eq, > u32 flags) > { > - struct panfrost_device *ptdev =3D dev_get_drvdata(dev); > + struct panfrost_device *pfdev =3D dev_get_drvdata(dev); > struct dev_pm_opp *opp; > int err; > =20 > @@ -40,7 +40,7 @@ static int panfrost_devfreq_target(struct device *dev, = unsigned long *freq, > =20 > err =3D dev_pm_opp_set_rate(dev, *freq); > if (!err) > - ptdev->pfdevfreq.current_frequency =3D *freq; > + pfdev->pfdevfreq.current_frequency =3D *freq; > =20 > return err; > }