From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
wangpeiyang1@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net 1/2] net: hibmcge: fix incorrect statistics update issue
Date: Wed, 21 May 2025 10:12:28 +0100 [thread overview]
Message-ID: <20250521091228.GS365796@horms.kernel.org> (raw)
In-Reply-To: <20250517095828.1763126-2-shaojijie@huawei.com>
On Sat, May 17, 2025 at 05:58:27PM +0800, Jijie Shao wrote:
> When the user dumps statistics, the hibmcge driver automatically
> updates all statistics. If the driver is performing the reset operation,
> the error data of 0xFFFFFFFF is updated.
>
> Therefore, if the driver is resetting, the hbg_update_stats_by_info()
> needs to return directly.
>
> Fixes: c0bf9bf31e79 ("net: hibmcge: Add support for dump statistics")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-21 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 9:58 [PATCH v2 net 0/2] There are some bugfix for hibmcge driver Jijie Shao
2025-05-17 9:58 ` [PATCH v2 net 1/2] net: hibmcge: fix incorrect statistics update issue Jijie Shao
2025-05-21 9:12 ` Simon Horman [this message]
2025-05-17 9:58 ` [PATCH v2 net 2/2] net: hibmcge: fix wrong ndo.open() after reset fail issue Jijie Shao
2025-05-21 9:12 ` Simon Horman
2025-05-21 23:00 ` [PATCH v2 net 0/2] There are some bugfix for hibmcge driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521091228.GS365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox