* [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe()
@ 2025-02-19 16:17 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-02-19 16:17 UTC (permalink / raw)
To: Vishal Bhakta, Broadcom internal kernel review list,
James E.J. Bottomley, Martin K. Petersen
Cc: Thorsten Blum, Christophe JAILLET, linux-scsi, linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
warning.
Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/scsi/vmw_pvscsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 32242d86cf5b..4927c6a33bd8 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pci.h>
+#include <linux/string_choices.h>
#include <scsi/scsi.h>
#include <scsi/scsi_host.h>
@@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto out_reset_adapter;
adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true);
- printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n",
- adapter->use_req_threshold ? "en" : "dis");
+ pr_debug("vmw_pvscsi: driver-based request coalescing %s\n",
+ str_enabled_disabled(adapter->use_req_threshold));
if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) {
printk(KERN_INFO "vmw_pvscsi: using MSI%s\n",
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe()
@ 2025-03-11 11:34 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-03-11 11:34 UTC (permalink / raw)
To: Vishal Bhakta, Broadcom internal kernel review list,
James E.J. Bottomley, Martin K. Petersen
Cc: Thorsten Blum, Christophe JAILLET, linux-scsi, linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
warning.
Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/scsi/vmw_pvscsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 32242d86cf5b..4927c6a33bd8 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pci.h>
+#include <linux/string_choices.h>
#include <scsi/scsi.h>
#include <scsi/scsi_host.h>
@@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto out_reset_adapter;
adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true);
- printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n",
- adapter->use_req_threshold ? "en" : "dis");
+ pr_debug("vmw_pvscsi: driver-based request coalescing %s\n",
+ str_enabled_disabled(adapter->use_req_threshold));
if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) {
printk(KERN_INFO "vmw_pvscsi: using MSI%s\n",
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe()
@ 2025-04-22 17:51 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-04-22 17:51 UTC (permalink / raw)
To: Vishal Bhakta, Broadcom internal kernel review list,
James E.J. Bottomley, Martin K. Petersen
Cc: Thorsten Blum, Christophe JAILLET, linux-scsi, linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
warning.
Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/scsi/vmw_pvscsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 32242d86cf5b..4927c6a33bd8 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pci.h>
+#include <linux/string_choices.h>
#include <scsi/scsi.h>
#include <scsi/scsi_host.h>
@@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto out_reset_adapter;
adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true);
- printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n",
- adapter->use_req_threshold ? "en" : "dis");
+ pr_debug("vmw_pvscsi: driver-based request coalescing %s\n",
+ str_enabled_disabled(adapter->use_req_threshold));
if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) {
printk(KERN_INFO "vmw_pvscsi: using MSI%s\n",
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe()
@ 2025-05-21 12:12 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-05-21 12:12 UTC (permalink / raw)
To: Vishal Bhakta, Broadcom internal kernel review list,
James E.J. Bottomley, Martin K. Petersen
Cc: Thorsten Blum, Christophe JAILLET, linux-scsi, linux-kernel
Remove hard-coded strings by using the str_enabled_disabled() helper
function.
Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
warning.
Suggested-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/scsi/vmw_pvscsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 32242d86cf5b..4927c6a33bd8 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pci.h>
+#include <linux/string_choices.h>
#include <scsi/scsi.h>
#include <scsi/scsi_host.h>
@@ -1508,8 +1509,8 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto out_reset_adapter;
adapter->use_req_threshold = pvscsi_setup_req_threshold(adapter, true);
- printk(KERN_DEBUG "vmw_pvscsi: driver-based request coalescing %sabled\n",
- adapter->use_req_threshold ? "en" : "dis");
+ pr_debug("vmw_pvscsi: driver-based request coalescing %s\n",
+ str_enabled_disabled(adapter->use_req_threshold));
if (adapter->dev->msix_enabled || adapter->dev->msi_enabled) {
printk(KERN_INFO "vmw_pvscsi: using MSI%s\n",
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-21 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 12:12 [RESEND PATCH] scsi: vmw_pvscsi: Use str_enabled_disabled() helper in pvscsi_probe() Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2025-04-22 17:51 Thorsten Blum
2025-03-11 11:34 Thorsten Blum
2025-02-19 16:17 Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).