From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, skalluru@marvell.com, manishc@marvell.com,
andrew+netdev@lunn.ch, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
tariqt@nvidia.com, saeedm@nvidia.com, louis.peens@corigine.com,
shshaikh@marvell.com, GR-Linux-NIC-Dev@marvell.com,
ecree.xilinx@gmail.com, horms@kernel.org, dsahern@kernel.org,
ruanjinjie@huawei.com, mheib@redhat.com,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
linux-net-drivers@amd.com, leon@kernel.org
Subject: Re: [PATCH net-next 2/3] udp_tunnel: remove rtnl_lock dependency
Date: Wed, 21 May 2025 15:31:07 -0700 [thread overview]
Message-ID: <20250521153107.150f01e1@kernel.org> (raw)
In-Reply-To: <aC4FK0fmUoaXYt4k@mini-arch>
On Wed, 21 May 2025 09:54:03 -0700 Stanislav Fomichev wrote:
> > > enum udp_tunnel_nic_info_flags {
> > > - /* Device callbacks may sleep */
> > > - UDP_TUNNEL_NIC_INFO_MAY_SLEEP = BIT(0),
> >
> > Could we use a different lock for sleeping and non-sleeping drivers?
>
> We can probably do it if we reorder the locks (as you ask/suggest
> below). Overall, I'm not sure I understand why we want to have two
> paths here. If we can do everything via work queue, why have a separate
> path for the non-sleepable callback? (more code -> more bugs)
I think when I was pulling this code out of the drivers I was trying
to preserve the fast path for drivers which don't have to sleep.
But if some drivers are okay with the wq then the mechanism must work,
so I guess you're right, it should be fine to make all go via wq.
next prev parent reply other threads:[~2025-05-21 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 20:36 [PATCH net-next 0/3] udp_tunnel: remove rtnl_lock dependency Stanislav Fomichev
2025-05-20 20:36 ` [PATCH net-next 1/3] net: ASSERT_RTNL remove netif_set_real_num_{rx,tx}_queues Stanislav Fomichev
2025-05-21 5:14 ` [Intel-wired-lan] [PATCH net-next 1/3] net: ASSERT_RTNL remove netif_set_real_num_{rx, tx}_queues Loktionov, Aleksandr
2025-05-21 17:01 ` Stanislav Fomichev
2025-05-20 20:36 ` [PATCH net-next 2/3] udp_tunnel: remove rtnl_lock dependency Stanislav Fomichev
2025-05-21 14:34 ` Jakub Kicinski
2025-05-21 16:54 ` Stanislav Fomichev
2025-05-21 22:31 ` Jakub Kicinski [this message]
2025-05-20 20:36 ` [PATCH net-next 3/3] Revert "bnxt_en: bring back rtnl_lock() in the bnxt_open() path" Stanislav Fomichev
2025-05-21 5:15 ` [Intel-wired-lan] " Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521153107.150f01e1@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-rdma@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=manishc@marvell.com \
--cc=mheib@redhat.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
--cc=shshaikh@marvell.com \
--cc=skalluru@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=stfomichev@gmail.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).