Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new()

Luca Ceresoli
2025-05-22T10:11:06Z

On Thu, 22 May 2025 10:50:24 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:

> On Wed, May 07, 2025 at 03:19:13PM +0300, Cosmin Tanislav wrote:
> > In preparation for adding multiple flags that change the behavior,
> > add a flags parameter to i2c_atr_new() and an i2c_atr_flags enum.
> >
> > Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> > Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
>
> How did you guys get it to build?

I haven't :-)

I just reviewed the code, and apparently gcc's parser is stricter than
I am.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering