Re: [PATCH v5 1/9] i2c: atr: Fix lockdep for nested ATRs

Luca Ceresoli
2025-05-22T10:09:04Z

Hi,

bleurgh. Sent by mistake before I finished writing. :-/

On Thu, 22 May 2025 12:07:13 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> On Thu, 22 May 2025 11:06:06 +0200
> Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
>
> > On Wed, May 07, 2025 at 03:19:07PM +0300, Cosmin Tanislav wrote:
> > > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > >
> > > When we have an ATR, and another ATR as a subdevice of the first ATR,
> > > we get lockdep warnings for the i2c_atr.lock and
> > > i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
> > > for the locks, and doesn't see the locks of the separate ATR instances
> > > as separate.
> > >
> > > Fix this by generating a dynamic lock key per lock instance.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > > Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> >
> > Your SoB is missing. I will add it for you if you confirm here.
>
> Mine? I didn't think it would be needed based on:
>
> > The Signed-off-by: tag indicates that the signer was involved in the
> > development of the patch, or that he/she was in the patch’s delivery
> > path.
>
> I'm not involved in the development, and "being in the delivery path" is probably not clear enought to me.

However, if it is needed, I confirm you can add my:

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering