From: David Laight <david.laight.linux@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] container_of: Document container_of() is not to be used in new code
Date: Thu, 22 May 2025 22:01:42 +0100 [thread overview]
Message-ID: <20250522220142.14876993@pumpkin> (raw)
In-Reply-To: <2025052121-drastic-hacker-aab6@gregkh>
On Wed, 21 May 2025 15:31:36 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Wed, May 21, 2025 at 03:27:19PM +0200, Greg Kroah-Hartman wrote:
...
> I tried it for the whole tree, and ugh, there are some real "errors" in
> there. The nfs inode handling logic is crazy, passing in a const
> pointer and then setting fields in it. So this will be some real work
> to unwind and fix in some places.
Perhaps change the really dodgy ones to container_of_deconst().
And fix the easy ones so they compile with the 'const' check.
Then most code will just contain container_of() and be fine and
not need churning.
So you'd have container_of_deconst() which is the old container_of() code
and contain_of_const() that preserves constness.
Then container_of() which is compile time selectable (for now) between them.
Get one of the build bots to enable it and things will slowly get fixed.
David
next prev parent reply other threads:[~2025-05-22 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 10:34 [PATCH 1/1] container_of: Document container_of() is not to be used in new code Sakari Ailus
2025-05-20 14:16 ` Andy Shevchenko
2025-05-20 14:30 ` Greg Kroah-Hartman
2025-05-20 22:09 ` Sakari Ailus
2025-05-21 13:27 ` Greg Kroah-Hartman
2025-05-21 13:31 ` Greg Kroah-Hartman
2025-05-21 13:43 ` Greg Kroah-Hartman
2025-05-22 13:47 ` Greg Kroah-Hartman
2025-05-22 21:01 ` David Laight [this message]
2025-05-23 8:36 ` Greg Kroah-Hartman
2025-05-24 12:45 ` David Laight
2025-05-24 15:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522220142.14876993@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox