From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9975C2D323F; Thu, 22 May 2025 23:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747956236; cv=none; b=sUWxBt+PJ1X4Vq3DX2C3lKDk1JaZcXpX0/4a5NJMYXAKO/leutf+ecCIXWuJkWNnd7pFsmureYhMy6+tJNI0T4+jh/o7rybaEBCvT5V/UjGH4Y03mZqVi6VOMwRznhjfOQSHkbxzF7PWuzoofww+/nJbkTKDjrgapWlaNYrrAAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747956236; c=relaxed/simple; bh=0WV3S2hggEo8UB79jSOkfPluYQMTTXi8KwtvSdvTY18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MKBvChy9k8DcbTFQ0RyGI1o8pS/7m0/V/W3WKgoJ4wcv3eUMg08MHf9d3EEcRDiXNBMmV6MPnmjaXMjxEzcLi9D0busAiSQJVk9GZO0sZiRKCrtT5dWOQtBIVbwNjekZkR1Fgpe3vhEKLGVh5G637wOdEIl4rbSfZ77sq9hF70w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AJiY9s6O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AJiY9s6O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC70DC4CEE4; Thu, 22 May 2025 23:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747956236; bh=0WV3S2hggEo8UB79jSOkfPluYQMTTXi8KwtvSdvTY18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AJiY9s6OH7qIicXuS2Ll0QHIyK6j/AWpefUUSdt4LQ8yVlNr6r7iGmcfjJspy//UT jgaj7B41td+8JM3OWqEiS6RXnYRM3z3RUfzS0psqsia66YER2qk0nNDZ5OvejnXPUD IetaDWdOi8KHzJujxUQIjzh5a48tnUttgj3L3a/A4a1eG0609Tp7G1fM1frR+kT3Rs TH6SOIdq6VWqnjbkOJc4abab2sCHcYURXPg0goPTRyEEXrJ3CIkCB+Txy0aTFkKAMh KG+4EYdIPQkdKIWsvoNC5oqxexQCSZDyG0/AlE+V/1OVG6XW0Ie8/vrovK6d8w+H2R KH0Sm/rRbQHcQ== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Jon Pan-Doh , Karolina Stolarek , Weinan Liu , Martin Petersen , Ben Fuller , Drew Walton , Anil Agrawal , Tony Luck , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sathyanarayanan Kuppuswamy , Lukas Wunner , Jonathan Cameron , Sargun Dhillon , "Paul E . McKenney" , Mahesh J Salgaonkar , Oliver O'Halloran , Kai-Heng Feng , Keith Busch , Robert Richter , Terry Bowman , Shiju Jose , Dave Jiang , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH v8 07/20] PCI/AER: Move aer_print_source() earlier in file Date: Thu, 22 May 2025 18:21:13 -0500 Message-ID: <20250522232339.1525671-8-helgaas@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250522232339.1525671-1-helgaas@kernel.org> References: <20250522232339.1525671-1-helgaas@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bjorn Helgaas Move aer_print_source() earlier in the file so a future change can use it from aer_print_error(), where it's easier to rate limit it. Signed-off-by: Bjorn Helgaas Tested-by: Krzysztof Wilczyński Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Ilpo Järvinen Reviewed-by: Jonathan Cameron Link: https://patch.msgid.link/20250520215047.1350603-8-helgaas@kernel.org --- drivers/pci/pcie/aer.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index 8b23ef90345b..c0481550363b 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -696,6 +696,19 @@ static void __aer_print_error(struct pci_dev *dev, pci_dev_aer_stats_incr(dev, info); } +static void aer_print_source(struct pci_dev *dev, struct aer_err_info *info, + bool found) +{ + u16 source = info->id; + + pci_info(dev, "%s%s error message received from %04x:%02x:%02x.%d%s\n", + info->multi_error_valid ? "Multiple " : "", + aer_error_severity_string[info->severity], + pci_domain_nr(dev->bus), PCI_BUS_NUM(source), + PCI_SLOT(source), PCI_FUNC(source), + found ? "" : " (no details found"); +} + void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) { int layer, agent; @@ -733,19 +746,6 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) info->severity, info->tlp_header_valid, &info->tlp); } -static void aer_print_source(struct pci_dev *dev, struct aer_err_info *info, - bool found) -{ - u16 source = info->id; - - pci_info(dev, "%s%s error message received from %04x:%02x:%02x.%d%s\n", - info->multi_error_valid ? "Multiple " : "", - aer_error_severity_string[info->severity], - pci_domain_nr(dev->bus), PCI_BUS_NUM(source), - PCI_SLOT(source), PCI_FUNC(source), - found ? "" : " (no details found"); -} - #ifdef CONFIG_ACPI_APEI_PCIEAER int cper_severity_to_aer(int cper_severity) { -- 2.43.0