From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Abel Vesa <abel.vesa@linaro.org>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH 2/7] phy: phy-snps-eusb2: fix repeater imbalance on phy_init() failure
Date: Fri, 23 May 2025 10:48:34 +0200 [thread overview]
Message-ID: <20250523084839.11015-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20250523084839.11015-1-johan+linaro@kernel.org>
Make sure to disable the repeater PHY also on phy_init() failure.
Fixes: 3584f6392f09 ("phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater")
Cc: Abel Vesa <abel.vesa@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/phy-snps-eusb2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
index 19af3f99692c..a799c3d2bcfb 100644
--- a/drivers/phy/phy-snps-eusb2.c
+++ b/drivers/phy/phy-snps-eusb2.c
@@ -468,7 +468,7 @@ static int snps_eusb2_hsphy_init(struct phy *p)
ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks);
if (ret) {
dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
- goto disable_vreg;
+ goto exit_repeater;
}
ret = reset_control_assert(phy->phy_reset);
@@ -493,7 +493,8 @@ static int snps_eusb2_hsphy_init(struct phy *p)
disable_ref_clk:
clk_bulk_disable_unprepare(phy->data->num_clks, phy->clks);
-
+exit_repeater:
+ phy_exit(phy->repeater);
disable_vreg:
regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs);
--
2.49.0
next prev parent reply other threads:[~2025-05-23 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 8:48 [PATCH 0/7] phy: phy-snps-eusb2: fixes and cleanups Johan Hovold
2025-05-23 8:48 ` [PATCH 1/7] phy: phy-snps-eusb2: fix clock imbalance on phy_exit() Johan Hovold
2025-05-25 13:17 ` Ivaylo Ivanov
2025-05-26 7:49 ` neil.armstrong
2025-05-23 8:48 ` Johan Hovold [this message]
2025-05-26 7:49 ` [PATCH 2/7] phy: phy-snps-eusb2: fix repeater imbalance on phy_init() failure Neil Armstrong
2025-05-23 8:48 ` [PATCH 3/7] phy: phy-snps-eusb2: rename phy_init() clock error label Johan Hovold
2025-05-26 7:49 ` neil.armstrong
2025-05-23 8:48 ` [PATCH 4/7] phy: phy-snps-eusb2: clean up error messages Johan Hovold
2025-05-26 7:50 ` neil.armstrong
2025-05-23 8:48 ` [PATCH 5/7] phy: phy-snps-eusb2: fix optional phy lookup parameter Johan Hovold
2025-05-26 8:27 ` neil.armstrong
2025-05-23 8:48 ` [PATCH 6/7] phy: phy-snps-eusb2: drop unnecessary loop index declarations Johan Hovold
2025-05-26 8:27 ` neil.armstrong
2025-05-23 8:48 ` [PATCH 7/7] phy: phy-snps-eusb2: clean up id table sentinel Johan Hovold
2025-05-23 8:57 ` [PATCH 0/7] phy: phy-snps-eusb2: fixes and cleanups Abel Vesa
2025-06-15 16:53 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523084839.11015-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).