From: Leo Yan <leo.yan@arm.com>
To: Yuanfang Zhang <quic_yuanfang@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] coresight: add coresight Trace Network On Chip driver
Date: Fri, 23 May 2025 09:56:55 +0100 [thread overview]
Message-ID: <20250523085655.GD2566836@e132581.arm.com> (raw)
In-Reply-To: <40599afc-4342-467c-87d8-3f53cbcfd242@quicinc.com>
On Fri, May 23, 2025 at 04:08:58PM +0800, Yuanfang Zhang wrote:
[...]
> >> +static int trace_noc_init_default_data(struct trace_noc_drvdata *drvdata)
> >> +{
> >> + int atid;
> >> +
> >> + atid = coresight_trace_id_get_system_id();
> >> + if (atid < 0)
> >> + return atid;
> >> +
> >> + drvdata->atid = atid;
> >
> > Do you need to expose this via sysfs ? Otherwise, how can you map
> > a trace to a TNOC at decoding ?
>
> yes, need to expose the atid via sysfs, but it better to expose it on source driver which connect with
> this TNOC. so dont expose it on this driver.
If so, why the ID is not maintained in coresight_path::trace_id?
A source device allocates ID and maintains in coresight path, then
this ID is passed (when enabling the link) to TNOC driver to consume it.
Thanks,
Leo
next prev parent reply other threads:[~2025-05-23 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 8:07 [PATCH v6 0/2] coresight: Add Coresight Trace Network On Chip driver Yuanfang Zhang
2025-05-22 8:07 ` [PATCH v6 1/2] dt-bindings: arm: Add device Trace Network On Chip definition Yuanfang Zhang
2025-05-22 8:07 ` [PATCH v6 2/2] coresight: add coresight Trace Network On Chip driver Yuanfang Zhang
2025-05-22 13:05 ` Leo Yan
2025-05-23 8:37 ` Yuanfang Zhang
2025-05-22 13:13 ` Suzuki K Poulose
2025-05-23 8:08 ` Yuanfang Zhang
2025-05-23 8:56 ` Leo Yan [this message]
2025-05-27 10:19 ` Suzuki K Poulose
2025-05-30 10:28 ` Yuanfang Zhang
2025-05-30 11:32 ` Suzuki K Poulose
2025-05-30 12:59 ` Leo Yan
2025-06-03 3:22 ` Yuanfang Zhang
2025-06-03 12:25 ` Leo Yan
2025-06-06 9:20 ` Yuanfang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523085655.GD2566836@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_yuanfang@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).