Re: [PATCH 2/2] iio: adc: ad4080: extend check for data lanes num

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 20 May 2025 15:09:25 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Tue, 2025-05-20 at 14:01 +0300, Antoniu Miclaus wrote:
> > Extend the check for st->num_lanes to ensure it is not greater
> > than 2, preventing invalid configurations.
> > 
> > The AD4080 only supports up to 2 data lanes.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
This is fine. I'll pick it up once I have a fixes tag for patch 1.
Send a v2 with that in place and picking up
Nuno's tags.

Thanks,

Jonathan

> 
> >  drivers/iio/adc/ad4080.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> > index c36eb41d738a..6e61787ed321 100644
> > --- a/drivers/iio/adc/ad4080.c
> > +++ b/drivers/iio/adc/ad4080.c
> > @@ -516,7 +516,7 @@ static int ad4080_properties_parse(struct ad4080_state
> > *st)
> >  
> >  	st->num_lanes = 1;
> >  	device_property_read_u32(dev, "adi,num-lanes", &st->num_lanes);
> > -	if (!st->num_lanes)
> > +	if (!st->num_lanes || st->num_lanes > 2)
> >  		return dev_err_probe(dev, -EINVAL,
> >  				     "Invalid 'adi,num-lanes' value: %u",
> >  				     st->num_lanes);