From: Heiko Carstens <hca@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-s390@vger.kernel.org, frankja@linux.ibm.com,
borntraeger@de.ibm.com, seiden@linux.ibm.com, nsg@linux.ibm.com,
nrb@linux.ibm.com, david@redhat.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, gor@linux.ibm.com, schlameuss@linux.ibm.com
Subject: Re: [PATCH v4 1/4] s390: remove unneeded includes
Date: Mon, 26 May 2025 10:28:39 +0200 [thread overview]
Message-ID: <20250526082839.13937B8b-hca@linux.ibm.com> (raw)
In-Reply-To: <20250523130348.247446-2-imbrenda@linux.ibm.com>
On Fri, May 23, 2025 at 03:03:45PM +0200, Claudio Imbrenda wrote:
> Many files don't need to include asm/tlb.h or asm/gmap.h.
> On the other hand, asm/tlb.h does need to include asm/gmap.h.
>
> Remove all unneeded includes so that asm/tlb.h is not directly used by
> s390 arch code anymore. Remove asm/gmap.h from a few other files as
> well, so that now only KVM code, mm/gmap.c, and asm/tlb.h include it.
>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
> ---
> arch/s390/include/asm/tlb.h | 1 +
> arch/s390/include/asm/uv.h | 1 -
> arch/s390/kvm/intercept.c | 1 +
> arch/s390/mm/fault.c | 1 -
> arch/s390/mm/gmap.c | 1 -
> arch/s390/mm/init.c | 1 -
> arch/s390/mm/pgalloc.c | 2 --
> arch/s390/mm/pgtable.c | 1 -
> 8 files changed, 2 insertions(+), 7 deletions(-)
Please change the subject so the first character after "s390: " is an
upper case character, like it is supposed to be the case for all s390
related patches. For "KVM: s390:" there seems to be no consistent
rule, but that's your playground.
Anyway:
Acked-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2025-05-26 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 13:03 [PATCH v4 0/4] KVM: s390: some cleanup and small fixes Claudio Imbrenda
2025-05-23 13:03 ` [PATCH v4 1/4] s390: remove unneeded includes Claudio Imbrenda
2025-05-26 8:28 ` Heiko Carstens [this message]
2025-05-23 13:03 ` [PATCH v4 2/4] KVM: s390: remove unneeded srcu lock Claudio Imbrenda
2025-05-23 13:03 ` [PATCH v4 3/4] KVM: s390: refactor and split some gmap helpers Claudio Imbrenda
2025-05-23 13:03 ` [PATCH v4 4/4] KVM: s390: simplify and move pv code Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526082839.13937B8b-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).