From: Jakub Kicinski <kuba@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, Jiri Pirko <jiri@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kselftest@vger.kernel.org, Moshe Shemesh <moshe@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next V10 1/6] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Tue, 27 May 2025 16:28:15 -0700 [thread overview]
Message-ID: <20250527162815.7c73d945@kernel.org> (raw)
In-Reply-To: <3dddb35c-d3cb-453d-8e60-70f241abd018@nvidia.com>
On Sun, 25 May 2025 17:57:28 +0300 Carolina Jubran wrote:
> >> + -
> >> + name: rate-tc-bw
> >> + type: u32
> >> + doc: |
> >> + Specifies the bandwidth allocation for the Traffic Class as a
> >> + percentage.
> >> + checks:
> >> + min: 0
> >> + max: 100
> >
> > Why in percentage? I don't think any existing param in devlink rate
> > or net shapers is in percentage right? Not according to what i can
> > grok about the uAPI.
> >
>
> I thought percentage might fit better here because it lets users clearly
> set the bandwidth share for each traffic class. While this isn’t the
> same as tx_weight in devlink-rate, the idea is related since both use
> relative values. If there isn’t a strong reason against it, I’d like to
> keep using percentages here.
The existing APIs use absolute values for b/w limits.
If you want to diverge please provide clear and realistic use cases.
next prev parent reply other threads:[~2025-05-27 23:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 18:38 [PATCH net-next V10 0/6] Support rate management on traffic classes in devlink and mlx5 Tariq Toukan
2025-05-20 18:38 ` [PATCH net-next V10 1/6] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2025-05-20 22:53 ` Jakub Kicinski
2025-05-25 14:57 ` Carolina Jubran
2025-05-27 23:28 ` Jakub Kicinski [this message]
2025-05-20 18:38 ` [PATCH net-next V10 2/6] selftest: netdevsim: Add devlink rate tc-bw test Tariq Toukan
2025-05-20 22:59 ` Jakub Kicinski
2025-05-21 7:05 ` Tariq Toukan
2025-05-21 14:10 ` Jakub Kicinski
2025-05-25 20:31 ` Gal Pressman
2025-05-21 21:05 ` Carolina Jubran
2025-05-21 22:24 ` Jakub Kicinski
2025-05-20 18:38 ` [PATCH net-next V10 3/6] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2025-05-20 18:38 ` [PATCH net-next V10 4/6] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2025-05-20 18:38 ` [PATCH net-next V10 5/6] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2025-05-20 18:38 ` [PATCH net-next V10 6/6] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527162815.7c73d945@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).