From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com
Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH V2 11/19] virtio_ring: switch to use vring_virtqueue for detach_unused_buf variants
Date: Wed, 28 May 2025 14:42:26 +0800 [thread overview]
Message-ID: <20250528064234.12228-12-jasowang@redhat.com> (raw)
In-Reply-To: <20250528064234.12228-1-jasowang@redhat.com>
Those variants are used internally so let's switch to use
vring_virtqueue as parameter to be consistent with other internal
virtqueue helpers.
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/virtio_ring.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 4af29a6e15e8..03b17bc275dd 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -950,9 +950,8 @@ static bool virtqueue_enable_cb_delayed_split(struct vring_virtqueue *vq)
return true;
}
-static void *virtqueue_detach_unused_buf_split(struct virtqueue *_vq)
+static void *virtqueue_detach_unused_buf_split(struct vring_virtqueue *vq)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
unsigned int i;
void *buf;
@@ -965,7 +964,7 @@ static void *virtqueue_detach_unused_buf_split(struct virtqueue *_vq)
buf = vq->split.desc_state[i].data;
detach_buf_split(vq, i, NULL);
vq->split.avail_idx_shadow--;
- vq->split.vring.avail->idx = cpu_to_virtio16(_vq->vdev,
+ vq->split.vring.avail->idx = cpu_to_virtio16(vq->vq.vdev,
vq->split.avail_idx_shadow);
END_USE(vq);
return buf;
@@ -1892,9 +1891,8 @@ static bool virtqueue_enable_cb_delayed_packed(struct vring_virtqueue *vq)
return true;
}
-static void *virtqueue_detach_unused_buf_packed(struct virtqueue *_vq)
+static void *virtqueue_detach_unused_buf_packed(struct vring_virtqueue *vq)
{
- struct vring_virtqueue *vq = to_vvq(_vq);
unsigned int i;
void *buf;
@@ -2642,8 +2640,8 @@ void *virtqueue_detach_unused_buf(struct virtqueue *_vq)
{
struct vring_virtqueue *vq = to_vvq(_vq);
- return vq->packed_ring ? virtqueue_detach_unused_buf_packed(_vq) :
- virtqueue_detach_unused_buf_split(_vq);
+ return vq->packed_ring ? virtqueue_detach_unused_buf_packed(vq) :
+ virtqueue_detach_unused_buf_split(vq);
}
EXPORT_SYMBOL_GPL(virtqueue_detach_unused_buf);
--
2.31.1
next prev parent reply other threads:[~2025-05-28 6:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 6:42 [PATCH V2 00/19] virtio_ring in order support Jason Wang
2025-05-28 6:42 ` [PATCH V2 01/19] virtio_ring: rename virtqueue_reinit_xxx to virtqueue_reset_xxx() Jason Wang
2025-05-28 6:42 ` [PATCH V2 02/19] virtio_ring: switch to use vring_virtqueue in virtqueue_poll variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 03/19] virtio_ring: unify logic of virtqueue_poll() and more_used() Jason Wang
2025-05-28 6:42 ` [PATCH V2 04/19] virtio_ring: switch to use vring_virtqueue for virtqueue resize variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 05/19] virtio_ring: switch to use vring_virtqueue for virtqueue_kick_prepare variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 06/19] virtio_ring: switch to use vring_virtqueue for virtqueue_add variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 07/19] virtio: " Jason Wang
2025-05-28 6:42 ` [PATCH V2 08/19] virtio_ring: switch to use vring_virtqueue for enable_cb_prepare variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 09/19] virtio_ring: use vring_virtqueue for enable_cb_delayed variants Jason Wang
2025-05-28 6:42 ` [PATCH V2 10/19] virtio_ring: switch to use vring_virtqueue for disable_cb variants Jason Wang
2025-05-28 6:42 ` Jason Wang [this message]
2025-05-28 6:42 ` [PATCH V2 12/19] virtio_ring: use u16 for last_used_idx in virtqueue_poll_split() Jason Wang
2025-05-28 6:42 ` [PATCH V2 13/19] virtio_ring: introduce virtqueue ops Jason Wang
2025-05-28 6:42 ` [PATCH V2 14/19] virtio_ring: determine descriptor flags at one time Jason Wang
2025-05-28 6:42 ` [PATCH V2 15/19] virtio_ring: factor out core logic of buffer detaching Jason Wang
2025-05-28 6:42 ` [PATCH V2 16/19] virtio_ring: factor out core logic for updating last_used_idx Jason Wang
2025-05-28 6:42 ` [PATCH V2 17/19] virtio_ring: factor out split indirect detaching logic Jason Wang
2025-05-28 6:42 ` [PATCH V2 18/19] virtio_ring: factor out split " Jason Wang
2025-05-28 6:42 ` [PATCH V2 19/19] virtio_ring: add in order support Jason Wang
2025-05-28 7:10 ` [PATCH V2 00/19] virtio_ring " Eugenio Perez Martin
2025-05-28 12:50 ` Michael S. Tsirkin
2025-05-29 2:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528064234.12228-12-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).