From: Jakub Kicinski <kuba@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net: af_key: Add error check in set_sadb_address()
Date: Wed, 28 May 2025 18:53:46 -0700 [thread overview]
Message-ID: <20250528185346.4eebf434@kernel.org> (raw)
In-Reply-To: <20250525155350.1948-1-vulab@iscas.ac.cn>
On Sun, 25 May 2025 23:53:50 +0800 Wentao Liang wrote:
> The function set_sadb_address() calls the function
> pfkey_sockaddr_fill(), but does not check its return value.
> A proper implementation can be found in set_sadb_kmaddress().
>
> Add an error check for set_sadb_address(), return error code
> if the function fails.
Please look at the callers, and you'll find out that the family has
already been validated.
--
pw-bot: reject
prev parent reply other threads:[~2025-05-29 1:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 15:53 [PATCH] net: af_key: Add error check in set_sadb_address() Wentao Liang
2025-05-26 8:58 ` Michal Swiatkowski
2025-05-29 1:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528185346.4eebf434@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).