From: Yi Sun <yi.sun@intel.com>
To: dave.jiang@intel.com, vinicius.gomes@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yi.sun@intel.com, xueshuai@linux.alibaba.com, gordon.jin@intel.com
Subject: [PATCH 1/2] dmaengine: idxd: Remove improper idxd_free
Date: Thu, 29 May 2025 23:34:30 +0800 [thread overview]
Message-ID: <20250529153431.1160067-1-yi.sun@intel.com> (raw)
The put_device() call can be asynchronous cleanup via schedule_delayed_work
when CONFIG_DEBUG_KOBJECT_RELEASE is set. This results in a use-after-free
failure during module unloading if invoking idxd_free() immediately
afterward.
Removes the improper call idxd_free() to prevent potential memory
corruption.
Signed-off-by: Yi Sun <yi.sun@intel.com>
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 760b7d81fcd8..504aca0fd597 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -1324,7 +1324,6 @@ static void idxd_remove(struct pci_dev *pdev)
idxd_cleanup(idxd);
pci_iounmap(pdev, idxd->reg_base);
put_device(idxd_confdev(idxd));
- idxd_free(idxd);
pci_disable_device(pdev);
}
--
2.43.0
next reply other threads:[~2025-05-29 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 15:34 Yi Sun [this message]
2025-05-29 15:34 ` [PATCH 2/2] dmaengine: idxd: Fix refcount underflow on module unload Yi Sun
2025-05-29 17:04 ` Vinicius Costa Gomes
2025-05-30 3:06 ` Yi Sun
2025-05-30 5:39 ` Shuai Xue
2025-05-30 5:58 ` Yi Sun
2025-05-29 16:56 ` [PATCH 1/2] dmaengine: idxd: Remove improper idxd_free Vinicius Costa Gomes
2025-05-30 0:24 ` Yi Sun
2025-05-30 1:07 ` Vinicius Costa Gomes
2025-05-30 1:42 ` Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529153431.1160067-1-yi.sun@intel.com \
--to=yi.sun@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gordon.jin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).