From: Greg KH <gregkh@linuxfoundation.org>
To: Kees Cook <kees@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Justin Stitt <justinstitt@google.com>,
Eric Biggers <ebiggers@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Jann Horn <jannh@google.com>, Marco Elver <elver@google.com>,
llvm@lists.linux.dev, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI
Date: Thu, 29 May 2025 06:47:12 +0200 [thread overview]
Message-ID: <2025052937-certainty-encode-4085@gregkh> (raw)
In-Reply-To: <202505281559.FD37A978F@keescook>
On Wed, May 28, 2025 at 04:00:03PM -0700, Kees Cook wrote:
> On Wed, May 28, 2025 at 02:32:23PM -0700, Nathan Chancellor wrote:
> > On Wed, May 28, 2025 at 11:26:22AM -0700, Kees Cook wrote:
> > > Depending on !COMPILE_TEST isn't sufficient to keep this feature out of
> > > CI because we can't stop it from being included in randconfig builds.
> > > This feature is still highly experimental, and is developed in lock-step
> > > with Clang's Overflow Behavior Types[1]. Depend on BROKEN to keep it
> > > from being enabled by anyone not expecting it.
> > >
> > > Link: https://discourse.llvm.org/t/rfc-v2-clang-introduce-overflowbehaviortypes-for-wrapping-and-non-wrapping-arithmetic/86507 [1]
> > > Signed-off-by: Kees Cook <kees@kernel.org>
> >
> > Should this have a 'Cc: stable@vger.kernel.org' on it? There might not
> > be much randconfig testing on stable but it is still very much possible
> > for some random user to turn this on and report problems.
>
> Ah yeah, I should probably do this via a proper Fixes: tag. I'll add
> this.
Nit, "Fixes:" tags alone without a cc: stable do not guarantee they will
end up in the stable trees. Always explicitly add a cc: please.
thanks,
greg k-h
next prev parent reply other threads:[~2025-05-29 4:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 18:26 [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI Kees Cook
2025-05-28 18:41 ` Eric Biggers
2025-05-28 21:32 ` Nathan Chancellor
2025-05-28 23:00 ` Kees Cook
2025-05-29 4:47 ` Greg KH [this message]
2025-05-29 6:00 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025052937-certainty-encode-4085@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ebiggers@kernel.org \
--cc=elver@google.com \
--cc=jannh@google.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).