[PATCH v2 1/2] iio: adc: ad4080: use lowercase device name

[PATCH v2 1/2] iio: adc: ad4080: use lowercase device name

[Antoniu Miclaus]

Update the .name field in the ad4080_chip_info struct
from "AD4080" to "ad4080" to follow the common convention
in IIO drivers of using lowercase names for device identifiers.

Fixes: 1ff3f56f846b ("iio: adc: ad4080: add driver support")
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v2:
 - drop "no functional changes" from commit body
 - add fixes tag
 drivers/iio/adc/ad4080.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index e8b2e5e7a68a..c36eb41d738a 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -433,7 +433,7 @@ static const struct iio_chan_spec ad4080_channel = {
 };
 
 static const struct ad4080_chip_info ad4080_chip_info = {
-	.name = "AD4080",
+	.name = "ad4080",
 	.product_id = AD4080_CHIP_ID,
 	.scale_table = ad4080_scale_table,
 	.num_scales = ARRAY_SIZE(ad4080_scale_table),
-- 
2.49.0

[PATCH v2 2/2] iio: adc: ad4080: extend check for data lanes num

[Antoniu Miclaus]

Extend the check for st->num_lanes to ensure it is not greater
than 2, preventing invalid configurations.

The AD4080 only supports up to 2 data lanes.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
no changes in v2.
 drivers/iio/adc/ad4080.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index c36eb41d738a..6e61787ed321 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -516,7 +516,7 @@ static int ad4080_properties_parse(struct ad4080_state *st)
 
 	st->num_lanes = 1;
 	device_property_read_u32(dev, "adi,num-lanes", &st->num_lanes);
-	if (!st->num_lanes)
+	if (!st->num_lanes || st->num_lanes > 2)
 		return dev_err_probe(dev, -EINVAL,
 				     "Invalid 'adi,num-lanes' value: %u",
 				     st->num_lanes);
-- 
2.49.0

Re: [PATCH v2 1/2] iio: adc: ad4080: use lowercase device name

[Jonathan Cameron]

On Mon, 26 May 2025 11:22:27 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Update the .name field in the ad4080_chip_info struct
> from "AD4080" to "ad4080" to follow the common convention
> in IIO drivers of using lowercase names for device identifiers.
> 
> Fixes: 1ff3f56f846b ("iio: adc: ad4080: add driver support")
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
I squashed both patches into the original commit as that is still
on a tree that I can rebase as I'll do that on rc1 anyway once available.

Thanks,

Jonathan

> ---
> changes in v2:
>  - drop "no functional changes" from commit body
>  - add fixes tag
>  drivers/iio/adc/ad4080.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> index e8b2e5e7a68a..c36eb41d738a 100644
> --- a/drivers/iio/adc/ad4080.c
> +++ b/drivers/iio/adc/ad4080.c
> @@ -433,7 +433,7 @@ static const struct iio_chan_spec ad4080_channel = {
>  };
>  
>  static const struct ad4080_chip_info ad4080_chip_info = {
> -	.name = "AD4080",
> +	.name = "ad4080",
>  	.product_id = AD4080_CHIP_ID,
>  	.scale_table = ad4080_scale_table,
>  	.num_scales = ARRAY_SIZE(ad4080_scale_table),